Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web console scaling #5177

Merged
merged 1 commit into from Oct 20, 2015
Merged

Web console scaling #5177

merged 1 commit into from Oct 20, 2015

Conversation

spadgett
Copy link
Member

Changes:

  • Adds a donut chart to the overview page with arrows for scaling deployments up and down.
  • Makes the desired replicas editable on the deployment page.
  • Adds pod warnings to the pod table and pod page.

This pull request requires #4999, which I've cherry picked, for the patternfly charts.

TODO:

  • Fix e2e test errors
  • Improve chart click behavior
  • Add "Pods" link back, somewhere
  • Make enter key work when editing replicas
  • Add field validation when editing replicas
  • Code cleanup
  • Add warnings for pods and pod pages (stretch)
  • Rebase on Show metrics on pod details page #4999 when available

Overview donut chart and scaling controls:

screen shot 2015-10-16 at 1 30 51 pm

Editing replicas on the deployment page:

openshift_web_console

openshift_web_console

Pod warnings:

screen shot 2015-10-18 at 10 53 17 am

screen shot 2015-10-18 at 10 53 13 am

@spadgett
Copy link
Member Author

/cc @jwforres, not quite ready for review...

@spadgett
Copy link
Member Author

https://trello.com/c/vGo6KaAQ

@spadgett
Copy link
Member Author

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5959/)

@spadgett
Copy link
Member Author

/cc @ajacobs21e

@spadgett spadgett force-pushed the scaling branch 5 times, most recently from 2c03728 to 7e3e1ce Compare October 19, 2015 19:05
@spadgett spadgett changed the title [WIP] - DO NOT MERGE - Add scaling to web UI Web console scaling Oct 19, 2015
@spadgett
Copy link
Member Author

@jwforres please review

jwforres
jwforres reviewed Oct 19, 2015
View reviewed changes
assets/app/scripts/directives/podChart.js
"use strict";

angular.module('openshiftConsole')
.directive('podChart', function($timeout, hashSizeFilter, isTroubledPodFilter, Logger) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe podStatusChart?

@spadgett
Copy link
Member Author

@jwforres updated

@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3693/) (Image: devenv-rhel7_2500)

@spadgett
Web console scaling
1c24a7a 
- Show pod status as a donut chart on the overview page
- Add scaling controls for each donut on the overview
- Make scaling editable on deployment page
- Add pod warnings to browse pods pages
@spadgett
Copy link
Member Author

Jenkins test errors:

     Warning: Running "less:development" (less) task
    >> FileError: '../../bower_components/patternfly/less/type.less' wasn't found. Tried - bower_components/patternfly/less/type.less,bower_components/patternfly/less/type.less,../../bower_components/patternfly/less/type.less in app/styles/main.less on line 63, column 1:
    >> 62 @import "@{pf-path}/tooltip.less";
    >> 63 @import "@{pf-path}/type.less";
    >> 64
    Warning: Error compiling app/styles/main.less Use --force to continue.

    Aborted due to warnings.

@spadgett
Copy link
Member Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1c24a7a

@spadgett
Copy link
Member Author

Minor one line fix for e2e error. Jenkins test is clean now. @jwforres FYI

[merge]

@spadgett
Copy link
Member Author

Unrelated failure. [merge] again.

!!! Error in hack/../test/end-to-end/core.sh:265
    'oadm prune images --keep-younger-than=0 --keep-tag-revisions=1 --confirm &>${LOG_DIR}/prune-images.log' exited with status 1
Call stack:
    1: hack/../test/end-to-end/core.sh:265 main(...)
Exiting with status 1
Error from server: User "e2e-pruner" cannot list all routes in the cluster

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1c24a7a

openshift-bot pushed a commit that referenced this pull request Oct 20, 2015
Merge pull request #5177 from spadgett/scaling
c6a3e3a 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit c6a3e3a into openshift:master Oct 20, 2015
@spadgett spadgett deleted the scaling branch October 21, 2015 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spadgett @openshift-bot @jwforres