-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit testing for LDAP group sync #5669
Merged
openshift-bot
merged 1 commit into
openshift:master
from
stevekuznetsov:skuznets/ldap-testing
Nov 30, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
pkg/cmd/experimental/syncgroups/ad/augmented_ldapinterface_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| package ad | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "gopkg.in/ldap.v2" | ||
|
|
||
| "github.com/openshift/origin/pkg/auth/ldaputil" | ||
| "github.com/openshift/origin/pkg/auth/ldaputil/testclient" | ||
| ) | ||
|
|
||
| func newTestAugmentedADLDAPInterface(client ldap.Client) *AugmentedADLDAPInterface { | ||
| // below are common test implementations of LDAPInterface fields | ||
| userQuery := ldaputil.LDAPQuery{ | ||
| BaseDN: "ou=users,dc=example,dc=com", | ||
| Scope: ldaputil.ScopeWholeSubtree, | ||
| DerefAliases: ldaputil.DerefAliasesAlways, | ||
| TimeLimit: 0, | ||
| Filter: "objectClass=inetOrgPerson", | ||
| } | ||
| groupMembershipAttributes := []string{"memberOf"} | ||
| userNameAttributes := []string{"cn"} | ||
| groupQuery := ldaputil.LDAPQueryOnAttribute{ | ||
| LDAPQuery: ldaputil.LDAPQuery{ | ||
| BaseDN: "ou=groups,dc=example,dc=com", | ||
| Scope: ldaputil.ScopeWholeSubtree, | ||
| DerefAliases: ldaputil.DerefAliasesAlways, | ||
| TimeLimit: 0, | ||
| Filter: "objectClass=groupOfNames", | ||
| }, | ||
| QueryAttribute: "dn", | ||
| } | ||
| groupNameAttributes := []string{"cn"} | ||
|
|
||
| return NewAugmentedADLDAPInterface(testclient.NewConfig(client), | ||
| userQuery, | ||
| groupMembershipAttributes, | ||
| userNameAttributes, | ||
| groupQuery, | ||
| groupNameAttributes) | ||
| } | ||
|
|
||
| // newDefaultTestGroup returns a new LDAP entry with the given CN | ||
| func newTestGroup(CN string) *ldap.Entry { | ||
| return ldap.NewEntry(fmt.Sprintf("cn=%s,ou=groups,dc=example,dc=com", CN), map[string][]string{"cn": {CN}}) | ||
| } | ||
|
|
||
| func TestGroupEntryFor(t *testing.T) { | ||
| var testCases = []struct { | ||
| name string | ||
| cacheSeed map[string]*ldap.Entry | ||
| client ldap.Client | ||
| baseDNOverride string | ||
| expectedError error | ||
| expectedEntry *ldap.Entry | ||
| }{ | ||
| { | ||
| name: "cached entries", | ||
| cacheSeed: map[string]*ldap.Entry{ | ||
| "cn=testGroup,ou=groups,dc=example,dc=com": newTestGroup("testGroup"), | ||
| }, | ||
| expectedError: nil, | ||
| expectedEntry: newTestGroup("testGroup"), | ||
| }, | ||
| { | ||
| name: "search request error", | ||
| baseDNOverride: "otherBaseDN", | ||
| expectedError: ldaputil.NewQueryOutOfBoundsError("cn=testGroup,ou=groups,dc=example,dc=com", "otherBaseDN"), | ||
| expectedEntry: nil, | ||
| }, | ||
| { | ||
| name: "search error", | ||
| client: testclient.NewMatchingSearchErrorClient(testclient.New(), "cn=testGroup,ou=groups,dc=example,dc=com", errors.New("generic search error")), | ||
| expectedError: errors.New("generic search error"), | ||
| expectedEntry: nil, | ||
| }, | ||
| { | ||
| name: "no error", | ||
| client: testclient.NewDNMappingClient( | ||
| testclient.New(), | ||
| map[string][]*ldap.Entry{ | ||
| "cn=testGroup,ou=groups,dc=example,dc=com": {newTestGroup("testGroup")}, | ||
| }, | ||
| ), | ||
| expectedError: nil, | ||
| expectedEntry: newTestGroup("testGroup"), | ||
| }, | ||
| } | ||
| for _, testCase := range testCases { | ||
| ldapInterface := newTestAugmentedADLDAPInterface(testCase.client) | ||
| if len(testCase.cacheSeed) > 0 { | ||
| ldapInterface.cachedGroups = testCase.cacheSeed | ||
| } | ||
| if len(testCase.baseDNOverride) > 0 { | ||
| ldapInterface.groupQuery.BaseDN = testCase.baseDNOverride | ||
| } | ||
| entry, err := ldapInterface.GroupEntryFor("cn=testGroup,ou=groups,dc=example,dc=com") | ||
| if !reflect.DeepEqual(err, testCase.expectedError) { | ||
| t.Errorf("%s: incorrect error returned:\n\texpected:\n\t%v\n\tgot:\n\t%v\n", testCase.name, testCase.expectedError, err) | ||
| } | ||
| if !reflect.DeepEqual(entry, testCase.expectedEntry) { | ||
| t.Errorf("%s: incorrect members returned:\n\texpected:\n\t%v\n\tgot:\n\t%v\n", testCase.name, testCase.expectedEntry, entry) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accept
groupsBaseDNandgroupsBaseFilteras args, so I don't have to know your harness when I try to use this.