Let users select log content without line numbers #5736
Conversation
| @@ -157,7 +156,7 @@ angular.module('openshiftConsole') | |||
|
|
|||
| // Append the line to the document fragment buffer. | |||
| var line = logLineTemplate.cloneNode(true); | |||
| line.childNodes[0].childNodes[0].appendChild(document.createTextNode(lastLineNumber)); | |||
| line.childNodes[0].appendChild(document.createTextNode(lastLineNumber)); | |||
There was a problem hiding this comment.
s/childNodes[0]/firstChild/?
spadgett
force-pushed
the
user-select-none
branch
from
4ec710f
to
ac8784a
Compare
| .flex(@columns: 0 0 60px); // set width of number column | ||
| .unselectable(); | ||
| border-right: 1px lighten(@log-bg-color, 10%) solid; | ||
| min-width: 60px; |
There was a problem hiding this comment.
do we actually need this much space, or can we shrink it further? might want to set white-space: nowrap; as well if you do
There was a problem hiding this comment.
ideally, a short log would reserve the minimal space for single or double-digit lines, and a long log would grow the left column to fit 4,5,6 digit numbers
There was a problem hiding this comment.
Need that much for 5 digits. I set that as a min to avoid the log content jumping to the right when we reach 100 or 1000 lines, but maybe it's not such a problem.
|
should we be doing width: 100% on the line text column, otherwise what happens when your first log line isn't very long? also you double checked the word break stuff? |
probably |
|
@jwforres It still fills the width with short lines. |
|
I checked word break. It's the same as before. |
in all browsers? |
|
Ah ha, the table width isn't 100%, but you can't tell because there are no borders and the parent sets the background black. |
|
ahhhh, wouldnt the hover effect be wrong then |
|
Yes, fixing... |
spadgett
force-pushed
the
user-select-none
branch
from
ac8784a
to
6221080
Compare
spadgett
changed the title
|
LGTM |
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 6221080 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7100/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3988/) (Image: devenv-rhel7_2695) |
|
re[merge] |
|
Evaluated for origin merge up to 6221080 |
Merged by openshift-bot
Add a mixin for browser prefixed user-select: none styles. Switch to a table for log content so user-select works properly in Safari.
/cc @jwforres