New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid mobile Safari zoom on input focus #5886
Conversation
I tested iPhone, iPad, Android (Chrome), and several desktop browsers. |
@@ -18,7 +18,7 @@ | |||
<div class="clearfix visible-xs-block"></div> | |||
<form class="" ng-show="imageStream" novalidate name="form"> | |||
<div style="margin-bottom: 15px;"> | |||
<div class="form-group form-group-lg"> | |||
<div class="form-group"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was form-group-lg doing before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It made the input slightly larger, which I personally didn't like since it didn't match the URL input below. It also caused zoom on the iPhone even with the font-size change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did I never notice that before, now I can't unsee it. Definitely fix.
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7099/) (Image: devenv-rhel7_2701) |
Evaluated for origin merge up to 32314fc |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 32314fc |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7099/) |
Merged by openshift-bot
took two hours to spot the difference. |
... in a good way, right? :) |
Fixes #3118
@jwforres PTAL