Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid mobile Safari zoom on input focus #5886

Merged
merged 1 commit into from Nov 13, 2015

Conversation

spadgett
Copy link
Member

Fixes #3118

@jwforres PTAL

@spadgett
Copy link
Member Author

I tested iPhone, iPad, Android (Chrome), and several desktop browsers.

@@ -18,7 +18,7 @@
<div class="clearfix visible-xs-block"></div>
<form class="" ng-show="imageStream" novalidate name="form">
<div style="margin-bottom: 15px;">
<div class="form-group form-group-lg">
<div class="form-group">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was form-group-lg doing before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It made the input slightly larger, which I personally didn't like since it didn't match the URL input below. It also caused zoom on the iPhone even with the font-size change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

openshift_web_console

After:

openshift_web_console

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did I never notice that before, now I can't unsee it. Definitely fix.

@jwforres jwforres added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2015
@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7099/) (Image: devenv-rhel7_2701)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 32314fc

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 32314fc

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7099/)

openshift-bot pushed a commit that referenced this pull request Nov 13, 2015
@openshift-bot openshift-bot merged commit b92eab7 into openshift:master Nov 13, 2015
@rettori
Copy link

rettori commented Nov 13, 2015

took two hours to spot the difference.

@spadgett spadgett deleted the ios-input-font-size branch November 13, 2015 17:36
@spadgett
Copy link
Member Author

took two hours to spot the difference.

... in a good way, right? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants