Update various templates to use status-icon #6083
Conversation
| @@ -38,7 +31,7 @@ | |||
| </span> | |||
| </dd> | |||
| </dl> | |||
| <h3>Configuration <span class="small" ng-if="buildConfigName">created from <a href="project/{{build.metadata.namespace}}/browse/builds/{{buildConfigName}}">{{buildConfigName}}</a></span></h3> | |||
| <h3>Configuration <span class="small" ng-if="buildConfigName">created from <a href="project/{{build.metadata.namespace}}/browse/builds/{{buildConfigName}}">{{buildConfigName}}</a></span></h3> | |||
There was a problem hiding this comment.
guessing you created a merge conflict with your other PR here, you can drop the whitespace fix
There was a problem hiding this comment.
or wait and rebase after your other one merges, but who knows when that will actually go through :)
There was a problem hiding this comment.
My editor does it automatically... I'll have to live with it I suppose unless I disable the feature. One day we won't have those issues anymore 😄
benjaminapetersen
force-pushed
the
bpeterse/refactor-status-icon
branch
from
27412c5
to
d14544d
Compare
|
[TEST] |
|
@jwforres updated the comments |
|
pretty sure this will end up with a merge conflict, but what the heck [merge] hopefully at least one of them passes and gets in :) |
openshift-bot
added
the
needs-rebase
benjaminapetersen
force-pushed
the
bpeterse/refactor-status-icon
branch
from
d14544d
to
b129a68
Compare
|
[TEST] rebased |
|
Evaluated for origin test up to b129a68 |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7546/) |
|
[merge] |
|
[merge]
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4216/) (Image: devenv-rhel7_2856) |
|
[merge] |
|
Evaluated for origin merge up to b129a68 |
…tus-icon Merged by openshift-bot
@jwforres @spadgett this is pt2 of breaking down this PR