Typo fixes #6089
Typo fixes #6089
Conversation
|
both forms are correct I think |
| @@ -55,7 +55,7 @@ type BuildStatus struct { | |||
| Phase BuildPhase `json:"phase" description:"observed point in the build lifecycle"` | |||
|
|
|||
| // Cancelled describes if a cancelling event was triggered for the build. | |||
| Cancelled bool `json:"cancelled,omitempty" description:"describes if a canceling event was triggered for the build"` | |||
| Cancelled bool `json:"cancelled,omitempty" description:"describes if a cancelling event was triggered for the build"` | |||
There was a problem hiding this comment.
You most probably need to update swagger for this change
./hack/update-generated-swagger-spec.sh
There was a problem hiding this comment.
same thing... should be "cancel" not "cancelling"
|
more or less, but we use the double L in our code + in the printed messages |
|
@Kargakis swagger updated. Thx for noticing :) |
ok, if it's decided between a {special,shady} committee behind closed doors then it looks good to me:) |
| @@ -15305,7 +15305,7 @@ | |||
| }, | |||
| "cancelled": { | |||
| "type": "boolean", | |||
| "description": "describes if a canceling event was triggered for the build" | |||
| "description": "describes if a cancelling event was triggered for the build" | |||
There was a problem hiding this comment.
shouldn't this be "describes if a cancel event was triggered for the build"
|
and 👍 for consistency for single vs double L.... even though double L looks very wrong to me, there is no way we are getting the api enumeration value changed at this point, and the single L is only accepted in american english anyway - http://grammarist.com/spelling/cancel/ |
|
@jwforres to be honest I was surprised myself that the double L version was the "more" correct one. Also I've changed the |
|
@jwforres is there anything else tbd ? |
|
[merge] |
|
@jwforres please re-merge. Failed due to flaky tests. |
|
opened flake issue #6149 [merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to ae4e36b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7583/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4201/) (Image: devenv-rhel7_2848) |
|
[merge] failure added to #6121 On Tue, Dec 1, 2015 at 1:05 PM, OpenShift Bot notifications@github.com
|
|
Evaluated for origin merge up to ae4e36b |
@Kargakis PTAL