Remove tooltip on delete button

[spadgett]

Allow the first touch to activate the button in mobile Safari.

https://bugzilla.redhat.com/show_bug.cgi?id=1284398

[spadgett]

@jwforres PTAL

[jwforres]

Honestly I'm wondering whether we should even have the tooltip popups on these. Does it really add much? We are prompting you afterward so it doesn't seem that bad.

[jwforres]

guessing it looked weird just having a link around the ?

[spadgett]

That's probably better. I always worry about adding an blue underline or border in some browser.

[spadgett]

Need to add the action-button class directly to the link or it turns the icon blue.

[jwforres]

Yeah that's fine. And if we remove the hover popup then we can use the
regular title attribute for the sr text.

On Tue, Dec 1, 2015 at 3:33 PM, Sam Padgett notifications@github.com
wrote:

In assets/app/views/directives/delete-button.html
#6152 (comment):

\ No newline at end of file

• <i class="fa fa-trash-o"
• ng-click="$event.stopPropagation(); openDeleteModal();"
• data-toggle="tooltip"
• data-placement="left"
• disable-popup-on-touch="true"
• title="Delete"
• aria-hidden="true">
• Delete {{resourceType | humanizeResourceType}} {{resourceName}}

Need to add the action-button class directly to the link or it turns the
icon blue.

—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/6152/files#r46334568.

[spadgett]

Yeah I made a similar comment in Bugzilla. I can just remove it.

I'm wondering if we shouldn't avoid popups as much as possible because of issues on mobile like #6153, #5880, and this one.

[spadgett]

@jwforres Updated to remove the tooltip entirely.

[jwforres]

I would expect this to just be a title attribute on the tag

[spadgett]

Are we sure that works across screen readers? I can't find definitively one way or the other. The general advice I see is to avoid title.

[jwforres]

[merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[spadgett]

W1202 10:30:48.766543   17841 pipeline.go:65] Could not find an image stream match for "mysql". Make sure that a Docker image with that tag is available on the node for the build to succeed.
FAIL
coverage: 59.3% of statements
FAIL    github.com/openshift/origin/pkg/generate/app/cmd    15.726s

[jwforres]

[merge]

[spadgett]

re[merge]

[openshift-bot]

Evaluated for origin test up to ebdddbc

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4238/) (Image: devenv-rhel7_2871)

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7625/)

[spadgett]

[merge]

[openshift-bot]

Evaluated for origin merge up to ebdddbc