Deflake policy startup issue #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liggitt
changed the title
|
[test] |
liggitt
changed the title
liggitt
changed the title
| @@ -177,6 +180,18 @@ func (c *MasterConfig) ensureComponentAuthorizationRules() { | |||
| glog.Errorf("Error creating bootstrap policy: %v", err) | |||
| } | |||
|
|
|||
| // Wait until the policy cache has caught up before continuing | |||
| err := wait.Poll(100*time.Millisecond, 30*time.Second, func() (done bool, err error) { | |||
There was a problem hiding this comment.
Wow that's a long interval.
|
addressed comments, also switched to always wait for the cache, even when there was an existing policy, to ensure later initialization steps don't fail because the policy cache wasn't up to date |
|
Evaluated for origin test up to a723137 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8022/) |
|
lgtm [merge] |
|
flake #6437, [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4457/) (Image: devenv-rhel7_3019) |
|
Evaluated for origin merge up to a723137 |
openshift-bot
pushed a commit
that referenced
this pull request
Dec 22, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with initial
ensurecalls not being allowed because the policy cache wasn't updated yet.Things like this: