SPDY roundtripper + proxy fixes #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @liggitt |
fabianofranz
changed the title
fabianofranz
force-pushed
the
bugs_1302422
branch
from
823816d
to
aaa2bca
Compare
fabianofranz
changed the title
|
LGTM, holding for rebase |
fabianofranz
force-pushed
the
bugs_1302422
branch
from
aaa2bca
to
5dc671f
Compare
fabianofranz
changed the title
|
@liggitt I added the other upstream commit (fixes proxy auth) to this PR. |
fabianofranz
force-pushed
the
bugs_1302422
branch
4 times, most recently
from
e122796
to
50287ff
Compare
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1407/) (Image: devenv-rhel7_3484) |
|
tests are failing consistently on the added unit test. might be related to the test server Close() call... not sure. untagging until we get a clean test run |
fabianofranz
force-pushed
the
bugs_1302422
branch
from
b85ca5c
to
5ebccd6
Compare
fabianofranz
force-pushed
the
bugs_1302422
branch
from
5ebccd6
to
f79894e
Compare
|
Evaluated for origin test up to f79894e |
|
looking good: retagging, [merge] |
|
👍 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1407/) |
|
Evaluated for origin merge up to f79894e |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 19, 2016
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1302422
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1302894