New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring .component to prevent weird wrapping issues #7396
Conversation
Visually, the changes look really good to me. |
&.meta-data { | ||
/* Left align for vertical layout at small sizes */ | ||
text-align: left; | ||
margin-left: 5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this introduced the extra margin at mobile widths.
Just the one comment. The changes look really good otherwise. Good to see the wrapping problems fixed. |
If you add "Fixes #6189" in the description, Github will close the issue when this merges. Generally prefer it there to the title where it looks like the PR number. |
Fixed the "Create route" issue and moved the issue number. Should be good now, @spadgett. |
LGTM [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5018/) (Image: devenv-rhel7_3467) |
Evaluated for origin merge up to 43f7610 |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 43f7610 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1317/) |
Merged by openshift-bot
@sg00dwin, @spadgett, @benjaminapetersen, @jwforres, @ajacobs21e, please review.
i made quite a few tweaks. a few highlights:
Fixes #6189