Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring .component to prevent weird wrapping issues #7396

Merged
merged 1 commit into from Feb 18, 2016
Merged

Refactoring .component to prevent weird wrapping issues #7396

merged 1 commit into from Feb 18, 2016

Conversation

rhamilto
Copy link
Member

@sg00dwin, @spadgett, @benjaminapetersen, @jwforres, @ajacobs21e, please review.

i made quite a few tweaks. a few highlights:

  • optimized existing responsive rules to be mobile first
  • changed the .meta-data font size to 11px so it's the same size as .component-label so that they both sit on the same baseline
  • changed the breakpoint where columns switch to rows from 768px to 992px so that the .meta-data only displays in the upper right of the box at medium and up sized screens
  • fixed bug where .component h2 didn't truncate consistently (in most cases, the h2 would render full width)
  • made each individual .port-mappings and .more-ports not wrap so all portions of each stay on the same line

Fixes #6189

@spadgett
Copy link
Member

Visually, the changes look really good to me.

@spadgett
Copy link
Member

Not sure if this is a new problem, but probably should get rid of the left margin when create route wraps this way.

openshift_web_console

&.meta-data {
/* Left align for vertical layout at small sizes */
text-align: left;
margin-left: 5px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this introduced the extra margin at mobile widths.

@spadgett
Copy link
Member

Just the one comment. The changes look really good otherwise. Good to see the wrapping problems fixed.

@spadgett
Copy link
Member

If you add "Fixes #6189" in the description, Github will close the issue when this merges. Generally prefer it there to the title where it looks like the PR number.

@spadgett spadgett self-assigned this Feb 17, 2016
@rhamilto
Copy link
Member Author

Fixed the "Create route" issue and moved the issue number. Should be good now, @spadgett.

screen shot 2016-02-18 at 8 54 10 am

@rhamilto rhamilto changed the title Refactoring .component to prevent weird wrapping issues #6189 Refactoring .component to prevent weird wrapping issues Feb 18, 2016
@spadgett
Copy link
Member

LGTM [merge]

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5018/) (Image: devenv-rhel7_3467)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 43f7610

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 43f7610

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1317/)

openshift-bot pushed a commit that referenced this pull request Feb 18, 2016
@openshift-bot openshift-bot merged commit 77de343 into openshift:master Feb 18, 2016
@rhamilto rhamilto deleted the service-port-text branch July 6, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web console service port text overflows box
3 participants