Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate wildcard certs against non-wildcard namedCertificate names #7399

Merged
merged 1 commit into from Feb 18, 2016
Merged

Validate wildcard certs against non-wildcard namedCertificate names #7399

merged 1 commit into from Feb 18, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 17, 2016

@deads2k
Copy link
Contributor

deads2k commented Feb 17, 2016

lgtm[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@liggitt
Copy link
Contributor Author

liggitt commented Feb 18, 2016

copr error, [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5013/) (Image: devenv-rhel7_3462)

@liggitt
Copy link
Contributor Author

liggitt commented Feb 18, 2016

unrelated new-app failure, [merge] [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to eb0ff4e

@deads2k
Copy link
Contributor

deads2k commented Feb 18, 2016

unrelated new-app failure, [merge] [test]

Did it have a specific "flake" indication in jenkins so they can vote on which flakes are the most important.

@liggitt
Copy link
Contributor Author

liggitt commented Feb 18, 2016

It had a cause detection, but no linked issue

@deads2k
Copy link
Contributor

deads2k commented Feb 18, 2016

It had a cause detection, but no linked issue

Specific or generic? Clayton's been adding generic ones that aren't related to flakes so that he doesn't have to look at the log.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to eb0ff4e

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1320/)

openshift-bot pushed a commit that referenced this pull request Feb 18, 2016
Merge pull request #7399 from liggitt/sni-validation
28cbd26 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 28cbd26 into openshift:master Feb 18, 2016
@liggitt liggitt deleted the sni-validation branch February 19, 2016 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liggitt @deads2k @openshift-bot