Set source of incremental build artifacts #7713
Conversation
|
First, let's try to reproduce the regression with our extended test: [testonlyextended][extended:core(incremental)] |
|
I've got actual code to fix the issue coming later. After fixing #7708 though, I run into this: $ oc start-build --follow wheelhouse-demo
wheelhouse-demo-7
W0301 14:48:36.620872 1 builder.go:55] Master version "v1.1.3-364-g9351b36-dirty" does not match Builder image version "v1.1.3-365-g3d84e2c-dirty"
I0301 14:48:36.674790 1 source.go:197] Downloading "https://github.com/GrahamDumpleton/wheelhouse-demo" ...
I0301 14:48:39.654226 1 install.go:236] Using "assemble" installed from "image:///usr/local/s2i/bin/assemble"
I0301 14:48:39.656735 1 install.go:236] Using "run" installed from "image:///usr/local/s2i/bin/run"
I0301 14:48:39.657464 1 install.go:236] Using "save-artifacts" installed from "<source-dir>/.s2i/bin/save-artifacts"
I0301 14:48:39.657964 1 util.go:186] Pulling image "172.30.168.107:5000/demo/wheelhouse-demo:latest" ...
E0301 14:48:42.120390 1 util.go:91] -----> Running save-artifacts
W0301 14:49:11.420081 1 sti.go:154] Clean build will be performed because of error saving previous build artifacts
E0301 14:49:11.420388 1 tar.go:290] Error reading next tar header: io: read/write on closed pipe
---> Installing application source
---> Building application from source
...So trying to fix the closed pipe problem as well, otherwise incremental builds would remain unusable. |
Using different image tags for build output and incremental build artifacts allows us to build with a random buildTag while getting artifacts from the stable pushTag.
rhcarvalho
force-pushed
the
incremental-builds-regression
branch
from
1e5b873
to
4737526
Compare
|
Evaluated for origin testonlyextended up to 4737526 |
rhcarvalho
changed the title
|
lgtm [merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 4737526 |
|
continuous-integration/openshift-jenkins/testonlyextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1849/) (Extended Tests: core(incremental)) |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1850/) (Extended Tests: core(incremental)) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5231/) (Image: devenv-rhel7_3641) |
|
[merge] |
|
Evaluated for origin merge up to 4737526 |
Using different image tags for build output and incremental build artifacts allows us to build with a disposable
buildTagwhile getting artifacts from the stablepushTag.Fixes #7708