Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller log font size for mobile #8136

Merged
merged 1 commit into from Mar 19, 2016

Conversation

spadgett
Copy link
Member

Switch to an 11px font <768px to show more log content on mobile devices (but keep 12px for desktop). Also dim the line numbers some to differentiate them from the log content.

/cc @jwforres @sg00dwin @benjaminapetersen

Mobile:

screen shot 2016-03-18 at 14 20 17

Desktop:

screen shot 2016-03-18 at 14 20 49

@spadgett
Copy link
Member Author

Current 12px font for comparison:

screen shot 2016-03-18 at 14 24 26

@jwforres
Copy link
Member

so looking at travis they actually use a lighter weight font as well on their line numbers to help make them visuall distinct

20160318_144743_

@jwforres
Copy link
Member

ok maybe my eyes are playing tricks on me, seems to be the same font/font-weight/font-size when i inspect it

but interestingly they use this to create their line numbers http://www.w3schools.com/cssref/pr_gen_counter-increment.asp

@benjaminapetersen
Copy link
Contributor

@jwforres we may possibly have been looking at Travis as well while discussing this change maybe....

@jwforres
Copy link
Member

[merge]

@jwforres jwforres added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2016
@jwforres jwforres added this to the 1.2.0 milestone Mar 18, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2314/) (Image: devenv-rhel7_3782)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 73bc9b8

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 73bc9b8

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2314/)

openshift-bot pushed a commit that referenced this pull request Mar 19, 2016
@openshift-bot openshift-bot merged commit f05961a into openshift:master Mar 19, 2016
@spadgett spadgett deleted the log-font-size branch March 22, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants