Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put new quota size in extended test #8788

Merged
merged 1 commit into from May 9, 2016

Conversation

gabemontero
Copy link
Contributor

@bparees @dgoodwin PTAL .... the conformance tests run this extended test.

@gabemontero
Copy link
Contributor Author

[testonlyextended][extended:core(quota)]

@openshift-bot
Copy link
Contributor

Evaluated for origin testonlyextended up to 6da3e66

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/163/) (Extended Tests: core(quota))

@gabemontero
Copy link
Contributor Author

ok cool the extended test that was failing now passed with the above run

@bparees
Copy link
Contributor

bparees commented May 7, 2016

lgtm but i don't want to muck w/ someone else's extended tests, so will let @dgoodwin sign off first.

@gabemontero
Copy link
Contributor Author

Cool / agreed

On Saturday, May 7, 2016, Ben Parees notifications@github.com wrote:

lgtm but i don't want to much w/ someone else's extended tests, so will
let @dgoodwin https://github.com/dgoodwin sign off first.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8788 (comment)

@dgoodwin
Copy link
Contributor

dgoodwin commented May 9, 2016

Nothing to it, LGTM, apologies I didn't think about that when I checked out your first PR @gabemontero

@bparees bparees modified the milestone: 1.2.0 May 9, 2016
@bparees
Copy link
Contributor

bparees commented May 9, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented May 9, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5847/) (Image: devenv-rhel7_4139)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 6da3e66

@gabemontero
Copy link
Contributor Author

Thanks for the confirm @dgoodwin - no worries

On Monday, May 9, 2016, Devan Goodwin notifications@github.com wrote:

Nothing to it, LGTM, apologies I didn't think about that when I checked
out your first PR @gabemontero https://github.com/gabemontero


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8788 (comment)

@gabemontero
Copy link
Contributor Author

Fixes #8789

@openshift-bot openshift-bot merged commit 706afc8 into openshift:master May 9, 2016
@gabemontero gabemontero deleted the fixLocalQuotaTest branch May 9, 2016 13:55
@bparees
Copy link
Contributor

bparees commented May 9, 2016

@gabemontero fixes needs to be in the PR description, not a comment, to auto-close an issue. I went ahead and closed #8789 manually.

@gabemontero
Copy link
Contributor Author

Ah - that's right - my bad - thanks @bparees

On Mon, May 9, 2016 at 10:31 AM, Ben Parees notifications@github.com
wrote:

@gabemontero https://github.com/gabemontero fixes needs to be in the PR
description, not a comment, to auto-close an issue. I went ahead and closed
#8789 #8789 manually.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8788 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants