Fix jshint warnings

[spadgett]

Fix the following jshint warnings:

assets❯ jshint app/scripts
app/scripts/controllers/create/createFromImage.js: line 200, col 17, Expected '{' and instead saw 'result'.
app/scripts/controllers/create/createFromImage.js: line 186, col 68, 'scope' is defined but never used.
app/scripts/controllers/create/createFromImage.js: line 304, col 56, 'key' is defined but never used.

app/scripts/controllers/create/nextSteps.js: line 89, col 10, Unnecessary semicolon.
app/scripts/controllers/create/nextSteps.js: line 100, col 10, Unnecessary semicolon.

app/scripts/controllers/edit/buildConfig.js: line 813, col 25, Missing semicolon.

app/scripts/controllers/modals/confirmReplaceModal.js: line 11, col 85, 'AlertMessageService' is defined but never used.

app/scripts/controllers/util/error.js: line 14, col 9, 'error_description' is defined but never used.
app/scripts/controllers/util/error.js: line 15, col 9, 'error_uri' is defined but never used.

@jwforres PTAL

[spadgett]

@jwforres @benjaminapetersen does hack/build-assets.sh not fail when there are jshint problems?

[jwforres]

[merge]

[jwforres]

may depend on whether they are warnings or errors? i have seen it fail before

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5855/) (Image: devenv-rhel7_4146)

[openshift-bot]

Evaluated for origin merge up to 283a2bc

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 283a2bc

[benjaminapetersen]

hmmm. yeah I was also under the impression build-assets would complain if any issues, though I've noticed build-assets vs test-assets can fail differently as well.

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3697/)

[benjaminapetersen]

+1 for consistency at least!