New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow map keys to be templatized #9324
Conversation
newKey := visitUnsettableValues(oldKey.Type(), oldKey, visitor) | ||
oldValue := v.MapIndex(oldKey) | ||
newValue := visitUnsettableValues(vt, oldValue, visitor) | ||
v.SetMapIndex(oldKey, reflect.Value{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really how you "remove" a value from a map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, this is go!
lgtm [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4857/) (Image: devenv-rhel7_4374) |
Evaluated for origin merge up to b469465 |
[Test]ing while waiting on the merge queue |
yum, re[test] |
Evaluated for origin test up to b469465 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4857/) |
Fixes #9321