Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary export #9511

Merged
merged 1 commit into from Aug 2, 2016
Merged

remove unnecessary export #9511

merged 1 commit into from Aug 2, 2016

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 23, 2016

Found while inspecting a false error indication triggered on Error from server: User "e2e-user" cannot list all buildconfigs in the cluster. Given the etcd dump, this is an unnecessary export.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 23, 2016

#5448 is being tagged incorrectly.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 23, 2016

[test]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2016
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Jul 1, 2016 •
edited

Changes mostly LGTM -- @deads2k is the etcd dump using curl the one that generates a file with one line of JSON? One of these dumps is immediately useful on Jenkins whereas the other requires those extra steps. Is there a simple way to ensure whichever one we're keeping is formatted to be useful?

Also, why should we prefer the curl over the cluster-admin dump?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 1, 2016

hack/load-etcd-dump.sh gives you an API server which you can hit with oc commands to debug your problem. status and describe are particularly useful when you're investigating the problem in a way that the object dump simply doesn't help.

Maybe that's not well known, I'll add it to the "maybe demo" list.

@stevekuznetsov
Copy link
Contributor

Ah, yes I vaguely remember you implementing that now. Decision to remove this now much better understood.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 1, 2016

rebased. still lgtm?

@stevekuznetsov
Copy link
Contributor

Still LGTM

@soltysh
Copy link
Member

soltysh commented Aug 1, 2016

LGTM [merge]

@soltysh soltysh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2016
@soltysh soltysh mentioned this pull request Aug 1, 2016
Closed
@mfojtik
Copy link
Member

mfojtik commented Aug 1, 2016

👍

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 1, 2016 •
edited

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7413/) (Image: devenv-rhel7_4730)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b2a2d3b

@deads2k
Copy link
Contributor Author

deads2k commented Aug 1, 2016

#9959 re[test]

@stevekuznetsov
Copy link
Contributor

re[test]

@soltysh
Copy link
Member

soltysh commented Aug 2, 2016

Flake: #9775

re-[merge]

@deads2k
Copy link
Contributor Author

deads2k commented Aug 2, 2016

re[test]

@deads2k
Copy link
Contributor Author

deads2k commented Aug 2, 2016

yum re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b2a2d3b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7390/)

@openshift-bot openshift-bot merged commit 4acf0ac into openshift:master Aug 2, 2016
@deads2k deads2k deleted the remove-unnecessary-export branch September 6, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stevekuznetsov stevekuznetsov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @stevekuznetsov @soltysh @mfojtik @openshift-bot