Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard code build name in extended tests #9605

Merged
merged 1 commit into from
Jul 1, 2016

Conversation

rhcarvalho
Copy link
Contributor

A previous version used to use 'out', lost in a refactor in #8591.

A previous version used to use 'out', lost in a refactor.
@rhcarvalho
Copy link
Contributor Author

rhcarvalho commented Jun 28, 2016

@bparees, I caught this while reading the build extended tests. PTAL.

@bparees
Copy link
Contributor

bparees commented Jun 28, 2016

if we're going to do it this way, i think we should log the buildname we got back from start-build. there have been issues where start-build returns some other value (not a build name) and the tests fail and it can be confusing to understand what happened.

@rhcarvalho
Copy link
Contributor Author

i think we should log the buildname we got back from start-build.

Check the line above the one I changed :)

@bparees
Copy link
Contributor

bparees commented Jun 28, 2016

lol. lgtm :)
[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0889626

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test ABORTED (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5499/)

@rhcarvalho
Copy link
Contributor Author

Hoping today Jenkins will be more determined to merge :)

@bparees
Copy link
Contributor

bparees commented Jun 30, 2016

not looking good so far :(
[merge]

@bparees
Copy link
Contributor

bparees commented Jun 30, 2016

[merge]

2 similar comments
@bparees
Copy link
Contributor

bparees commented Jun 30, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jun 30, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jun 30, 2016

quota bug and fuzzer bug.
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 1, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jul 1, 2016

flake #9672
and
#9490
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 1, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5702/) (Image: devenv-rhel7_4503)

@bparees
Copy link
Contributor

bparees commented Jul 1, 2016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0889626

@openshift-bot openshift-bot merged commit 178c585 into openshift:master Jul 1, 2016
@bparees
Copy link
Contributor

bparees commented Jul 1, 2016

10 merge tags. probably not even a record.

@rhcarvalho rhcarvalho deleted the followup-8591 branch July 1, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants