Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling multiline parameter injection for templates #9942

Merged
merged 1 commit into from Jul 22, 2016
Merged

Enabling multiline parameter injection for templates #9942

merged 1 commit into from Jul 22, 2016

Conversation

jupierce
Copy link
Contributor

Fixes #9863
Parameter regexp changed to allow multiline values. As @Miciah points out in #9863, multi-line values must be quoted.

oc new-app --dry-run --template=guestbook-example -p="\"PARM1=a
b
c
\",PARM2=5"

@jupierce
Copy link
Contributor Author

@bparees

@jupierce
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9baa286

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6507/)

@bparees
Copy link
Contributor

bparees commented Jul 19, 2016

lgtm [merge]

@bparees
Copy link
Contributor

bparees commented Jul 20, 2016

yum mirrors [merge]

@bparees
Copy link
Contributor

bparees commented Jul 21, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jul 21, 2016

known flakes. [merge]

@bparees
Copy link
Contributor

bparees commented Jul 21, 2016

[merge]

1 similar comment
@bparees
Copy link
Contributor

bparees commented Jul 21, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Jul 22, 2016

[merge]

On Thu, Jul 21, 2016 at 6:20 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6681/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9942 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3lmxzchFUkpH4jAWgmYqBLBzS6vIks5qX_C9gaJpZM4JQJCf
.

Ben Parees | OpenShift

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6699/) (Image: devenv-rhel7_4644)

@bparees
Copy link
Contributor

bparees commented Jul 22, 2016

[merge]

On Fri, Jul 22, 2016 at 12:15 AM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6694/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9942 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3qTFGACdHQarOtxB6gh3jp0Of_ilks5qYEPlgaJpZM4JQJCf
.

Ben Parees | OpenShift

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9baa286

@openshift-bot openshift-bot merged commit 12dab60 into openshift:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants