Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.10] OCPBUGS-1938: Bump fedora-coreos-config submodule for ISO mount fix #1025

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 30, 2022

Colin Walters (1):
      live-generator: Use a loop to work around potential races with udev on el8

I.e. coreos/fedora-coreos-config#1986

```
Colin Walters (1):
      live-generator: Use a loop to work around potential races with udev on el8
```

I.e. coreos/fedora-coreos-config#1986
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

@jlebon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.10] OCPBUGS-XXX: Bump fedora-coreos-config submodule for ISO mount fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@jlebon jlebon changed the title [release-4.10] OCPBUGS-XXX: Bump fedora-coreos-config submodule for ISO mount fix [release-4.10] OCPBUGS-1938: Bump fedora-coreos-config submodule for ISO mount fix Oct 3, 2022
@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Oct 3, 2022
@openshift-ci-robot
Copy link

@jlebon: This pull request references Jira Issue OCPBUGS-1938, which is invalid:

  • expected dependent Jira Issue OCPBUGS-1936 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
  • expected dependent Jira Issue OCPBUGS-1937 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead
  • expected dependent Jira Issue OCPBUGS-1936 to target a version in 4.11.0, 4.11.z, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Colin Walters (1):
     live-generator: Use a loop to work around potential races with udev on el8

I.e. coreos/fedora-coreos-config#1986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

@jlebon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.10] OCPBUGS-1938: Bump fedora-coreos-config submodule for ISO mount fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 3, 2022
@jlebon jlebon marked this pull request as ready for review October 3, 2022 20:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
@jlebon
Copy link
Member Author

jlebon commented Oct 3, 2022

FWIW, I've tested this commit on top of 4.10 manually already (see coreos/fedora-coreos-config#1986 (comment)). So we shouldn't get any surprises in the pipeline.

@cgwalters
Copy link
Member

From my PoV we should just bypass the official bug backport process for this; it's basically just overhead.

Crucially, only new nodes (or whole new clusters) will hit the new code, so risk of any wide fallout is really low.

@sdodson
Copy link
Member

sdodson commented Oct 3, 2022

We'll get things merged in order, the backport process is meant not only to ensure testing but to provide assurances that someone who was delivered this fix in 4.10.z doesn't then go repeat the process in 4.11 and lack the fixes. I'll grease the wheels so that 4.11 PR merges, it only needs lgtm now. Once that merges I'll make sure this gets in too.

@ashcrow ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 3, 2022
@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 3, 2022
@mike-nguyen
Copy link
Member

/backport-risk-assessed

@ashcrow ashcrow requested review from cgwalters and removed request for miabbott October 3, 2022 21:05
@ashcrow
Copy link
Member

ashcrow commented Oct 3, 2022

This backport still needs a lgtm

@ashcrow
Copy link
Member

ashcrow commented Oct 3, 2022

/test build-test-qemu

@mike-nguyen
Copy link
Member

/lgtm

@sdodson
Copy link
Member

sdodson commented Oct 3, 2022

Failure seems legit, 8.4 lacking newest os-tree?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member

It's a bug in our CI configuration here openshift/release#32820
(Which note, is distinct from the ART build configuration, which is its own problem)

The actual failure is because coreos/coreos-assembler#3114 merged, otherwise we might not have noticed CI was using cosa main.

@sdodson
Copy link
Member

sdodson commented Oct 3, 2022

/test build-test-qemu

@cgwalters
Copy link
Member

cgwalters commented Oct 3, 2022

OK fun, this is now hitting ye olde 9p issues coreos/coreos-assembler#1812

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e1583c4 and 2 for PR HEAD 33b0976 in total

@mike-nguyen
Copy link
Member

mike-nguyen commented Oct 3, 2022

I built RHCOS with this PR with no issues. The kola and testiso test also passed.

@mike-nguyen
Copy link
Member

/override ci/prow/build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@mike-nguyen: Overrode contexts on behalf of mike-nguyen: ci/prow/build-test-qemu

In response to this:

/override ci/prow/build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 453d7c0 into openshift:release-4.10 Oct 4, 2022
@openshift-ci-robot
Copy link

@jlebon: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1938 has been moved to the MODIFIED state.

In response to this:

Colin Walters (1):
     live-generator: Use a loop to work around potential races with udev on el8

I.e. coreos/fedora-coreos-config#1986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon deleted the pr/backport-loop-mount-4.10 branch April 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants