New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.10] OCPBUGS-1938: Bump fedora-coreos-config submodule for ISO mount fix #1025
[release-4.10] OCPBUGS-1938: Bump fedora-coreos-config submodule for ISO mount fix #1025
Conversation
``` Colin Walters (1): live-generator: Use a loop to work around potential races with udev on el8 ``` I.e. coreos/fedora-coreos-config#1986
@jlebon: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
@jlebon: This pull request references Jira Issue OCPBUGS-1938, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jlebon: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
FWIW, I've tested this commit on top of 4.10 manually already (see coreos/fedora-coreos-config#1986 (comment)). So we shouldn't get any surprises in the pipeline. |
From my PoV we should just bypass the official bug backport process for this; it's basically just overhead. Crucially, only new nodes (or whole new clusters) will hit the new code, so risk of any wide fallout is really low. |
We'll get things merged in order, the backport process is meant not only to ensure testing but to provide assurances that someone who was delivered this fix in 4.10.z doesn't then go repeat the process in 4.11 and lack the fixes. I'll grease the wheels so that 4.11 PR merges, it only needs lgtm now. Once that merges I'll make sure this gets in too. |
/backport-risk-assessed |
This backport still needs a lgtm |
/test build-test-qemu |
/lgtm |
Failure seems legit, 8.4 lacking newest os-tree? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's a bug in our CI configuration here openshift/release#32820 The actual failure is because coreos/coreos-assembler#3114 merged, otherwise we might not have noticed CI was using cosa main. |
/test build-test-qemu |
OK fun, this is now hitting ye olde 9p issues coreos/coreos-assembler#1812 /retest |
I built RHCOS with this PR with no issues. The kola and testiso test also passed. |
/override ci/prow/build-test-qemu |
@mike-nguyen: Overrode contexts on behalf of mike-nguyen: ci/prow/build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jlebon: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1938 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I.e. coreos/fedora-coreos-config#1986