Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.yaml: include the 25azure-udev-rules overlay from FCOS #1111

Merged
merged 2 commits into from Jan 21, 2023

Conversation

dustymabe
Copy link
Member

This was originally introduced in coreos/fedora-coreos-config#2176. Let's pick it up here in RHCOS too.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@dustymabe
Copy link
Member Author

I had originally added this commit to #1103 but the bot that managed that PR kicked it out so here it is in a new PR.

@dustymabe
Copy link
Member Author

/override ci/prow/rhcos-90-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/rhcos-90-build-test-qemu, ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/rhcos-90-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was originally introduced in coreos/fedora-coreos-config#2176.
Let's pick it up here in RHCOS too.
Dusty Mabe (1):
          overlay: rename azure overlay to conform with others
@dustymabe
Copy link
Member Author

ok this one should pass CI now.

@dustymabe dustymabe changed the title common.yaml: include the 25-azure-udev-rules overlay from FCOS common.yaml: include the 25azure-udev-rules overlay from FCOS Jan 20, 2023
@cgwalters
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,dustymabe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a2855f2 and 2 for PR HEAD 225c468 in total

@dustymabe
Copy link
Member Author

/test rhcos-86-build-test-qemu

2 similar comments
@dustymabe
Copy link
Member Author

/test rhcos-86-build-test-qemu

@dustymabe
Copy link
Member Author

/test rhcos-86-build-test-qemu

@dustymabe
Copy link
Member Author

/override ci/prow/rhcos-90-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2023

@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/rhcos-90-build-test-qemu, ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/rhcos-90-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2023

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9bee93f into openshift:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants