Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-5569: [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS #1113

Merged
merged 2 commits into from
Feb 8, 2023
Merged

OCPBUGS-5569: [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS #1113

merged 2 commits into from
Feb 8, 2023

Conversation

dustymabe
Copy link
Member

This was originally introduced in coreos/fedora-coreos-config#2176.
Let's pick it up here in RHCOS too.

(cherry picked from commit 42fc881)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2023

@dustymabe: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

common.yaml: include the 25azure-udev-rules overlay from FCOS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe changed the title common.yaml: include the 25azure-udev-rules overlay from FCOS [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS Jan 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2023

@dustymabe: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2023
@dustymabe
Copy link
Member Author

/hold

I need to do some testing on this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2023
@travier
Copy link
Member

travier commented Jan 26, 2023

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 26, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@dustymabe
Bump fedora-coreos-config
9924c3b 
Benjamin Gilbert (6):
      ci: detect unbracketed if expressions in shell scripts
      tests/kola: add test for Butane GRUB users sugar
      overlay/15fcos: retroactively fix BLS grub_users setting (CVE-2022-3675)
      tests/kola/butane/grub-users: correctly skip on s390x
      tests/kola/butane/grub-users-fix: increase timeout
      tests/kola/butane/grub-users-fix: increase timeout again

Dusty Mabe (9):
      denylist: extend snooze for tests affected by tmpfiles issue
      denylist: exclude ext.config.networking.nameserver on s390x
      denylist: aws.nvme: extend snooze and re-apply to all streams
      tests/default-network-behavior-change: update for NM 1.41.3+
      tests/default-network-behavior-change: drop unused EXPECTED_INITRD_NETWORK_CFG1
      overlay.d: create new 25-azure-udev-rules overlay
      overlay.d: add change/move to action for azure sriov rules
      .cci.jenkinsfile: disable testing on older RHCOS branch
      overlay: rename azure overlay to conform with others

Huijing Hei (2):
      tests: verify multiple nameservers config via kernel arguments work well
      s390x: not run ext.config.networking.nameserver

Jonathan Lebon (2):
      tests/kola/selinux: add test that policy isn't recompiled
      ci: bump memory request to 9Gi
@dustymabe
common.yaml: include the 25azure-udev-rules overlay from FCOS
18e96ed 
This was originally introduced in coreos/fedora-coreos-config#2176.
Let's pick it up here in RHCOS too.

(cherry picked from commit 42fc881)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@dustymabe
Copy link
Member Author

Finally got around to testing this with a local build. Should be good to go now.

@dustymabe dustymabe changed the title [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS OCPBUGS-5569: [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@dustymabe: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-5569: [release-4.12] common.yaml: include the 25azure-udev-rules overlay from FCOS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link

@dustymabe: This pull request references Jira Issue OCPBUGS-5569, which is invalid:

  • expected the bug to target the "4.12.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-5569 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This was originally introduced in coreos/fedora-coreos-config#2176.
Let's pick it up here in RHCOS too.

(cherry picked from commit 42fc881)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented Feb 7, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 7, 2023
@travier
Copy link
Member

travier commented Feb 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-nguyen
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-5569, which is invalid:

  • expected dependent Jira Issue OCPBUGS-7173 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Fixed) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mike-nguyen
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 7, 2023
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-5569, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7173 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7173 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 87d66db into openshift:release-4.12 Feb 8, 2023
@openshift-ci-robot
Copy link

@dustymabe: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5569 has been moved to the MODIFIED state.

In response to this:

This was originally introduced in coreos/fedora-coreos-config#2176.
Let's pick it up here in RHCOS too.

(cherry picked from commit 42fc881)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschintag jschintag Awaiting requested review from jschintag

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dustymabe @travier @openshift-ci-robot @mike-nguyen @openshift-merge-robot