Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-10275: Bump fedora-coreos-config #1219

Merged
merged 4 commits into from
May 22, 2023

Conversation

c4rt0
Copy link
Contributor

@c4rt0 c4rt0 commented Mar 27, 2023

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

@c4rt0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 27, 2023
@c4rt0 c4rt0 changed the title Bump fedora-coreos-config [rhcos-4.12] Bug 10275: Bump fedora-coreos-config Mar 27, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

@c4rt0: This pull request references Bugzilla bug 10275, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.12.z" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (WORKSFORME) instead
  • expected Bugzilla bug 10275 to depend on a bug targeting a release in 4.13.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[rhcos-4.12] Bug 10275: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0 c4rt0 marked this pull request as draft March 27, 2023 21:36
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2023
@travier
Copy link
Member

travier commented Mar 28, 2023

The title should be OCPBUGS-XYZ: ...

@c4rt0 c4rt0 changed the title [rhcos-4.12] Bug 10275: Bump fedora-coreos-config OCPBUGS-10236: Bump fedora-coreos-config Mar 28, 2023
@openshift-ci openshift-ci bot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci-robot
Copy link

@c4rt0: This pull request references Jira Issue OCPBUGS-10236, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Duplicate) instead
  • expected Jira Issue OCPBUGS-10236 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

Dusty Mabe (1):
overlay: rename azure overlay to conform with others

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@c4rt0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10236: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0 c4rt0 changed the title OCPBUGS-10236: Bump fedora-coreos-config OCPBUGS-10235: Bump fedora-coreos-config Mar 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci-robot
Copy link

@c4rt0: This pull request references Jira Issue OCPBUGS-10235, which is invalid:

  • expected the bug to target the "4.12.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-10235 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

Dusty Mabe (1):
overlay: rename azure overlay to conform with others

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@c4rt0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10235: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0 c4rt0 changed the title OCPBUGS-10235: Bump fedora-coreos-config OCPBUGS-10275: Bump fedora-coreos-config Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@c4rt0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10275: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. and removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci-robot
Copy link

@c4rt0: This pull request references Jira Issue OCPBUGS-10275, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

Dusty Mabe (1):
overlay: rename azure overlay to conform with others

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 8, 2023

/retest

@ravanelli
Copy link
Member

ravanelli commented May 9, 2023

/hold
see 9924c3b
overlay: rename azure overlay to conform with others Is already in the last bump. Can you rebase your PR? Can you update the commit message? Since it doesn't include it?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@openshift-ci-robot
Copy link

@c4rt0: This pull request references Jira Issue OCPBUGS-10275, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10274 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10274 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@c4rt0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-10275: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ci/prow-entrypoint.sh Outdated Show resolved Hide resolved
@c4rt0
Copy link
Contributor Author

c4rt0 commented May 11, 2023

Just for future reference:
Commit message of my previous version of fedora-coreos-config bump, included an additional commit that was already bumped. My question now is @ravanelli, what would have happened if it would be merged that way?

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 11, 2023

/retest-required

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 11, 2023

/jira refresh

@openshift-ci-robot
Copy link

@c4rt0: This pull request references Jira Issue OCPBUGS-10275, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10274 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10274 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 19, 2023

/retest-required

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 19, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@c4rt0: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented May 22, 2023

/unhold

@travier
Copy link
Member

travier commented May 22, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Member

travier commented May 22, 2023

We'll merge this as is to avoid going through another round of CI but make sure to squash fixup commits next time.

@openshift-merge-robot openshift-merge-robot merged commit fc6d548 into openshift:release-4.12 May 22, 2023
5 checks passed
@openshift-ci-robot
Copy link

@c4rt0: Jira Issue OCPBUGS-10275: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10275 has been moved to the MODIFIED state.

In response to this:

Colin Walters (1):
[rhcos-4.12] overlay/35-coreos-live: Lazily unmount /proc/cmdline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c4rt0
Copy link
Contributor Author

c4rt0 commented May 22, 2023

Absolutely, thanks Timothée!

@c4rt0 c4rt0 deleted the release-4.12 branch May 22, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants