Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11589: overlay: Inject SYSTEMD_JOURNAL_{COMPACT,KEYED_HASH}=0 #1248

Merged

Conversation

cgwalters
Copy link
Member

So that containers using rhel8 can read the host's journal directly.

xref https://issues.redhat.com/browse/LOG-3832

We can remove this in 4.14 hopefully, and almost certainly 4.15.

(cherry picked from commit 5bcda9b)

So that containers using rhel8 can read the host's journal
directly.

xref https://issues.redhat.com/browse/LOG-3832

We can remove this in 4.14 hopefully, and almost certainly 4.15.

(cherry picked from commit 5bcda9b)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

@cgwalters: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

overlay: Inject SYSTEMD_JOURNAL_{COMPACT,KEYED_HASH}=0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2023
@cgwalters cgwalters changed the title overlay: Inject SYSTEMD_JOURNAL_{COMPACT,KEYED_HASH}=0 OCPBUGS-11589: overlay: Inject SYSTEMD_JOURNAL_{COMPACT,KEYED_HASH}=0 Apr 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

@cgwalters: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11589: overlay: Inject SYSTEMD_JOURNAL_{COMPACT,KEYED_HASH}=0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 10, 2023
@openshift-ci-robot
Copy link

@cgwalters: This pull request references Jira Issue OCPBUGS-11589, which is invalid:

  • expected Jira Issue OCPBUGS-11589 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

So that containers using rhel8 can read the host's journal directly.

xref https://issues.redhat.com/browse/LOG-3832

We can remove this in 4.14 hopefully, and almost certainly 4.15.

(cherry picked from commit 5bcda9b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 10, 2023
@openshift-ci-robot
Copy link

@cgwalters: This pull request references Jira Issue OCPBUGS-11589, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11492 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11492 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen April 10, 2023 12:47
@cgwalters
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 10, 2023
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

@mike-nguyen I think you're the cherry pick approver here?

@mike-nguyen
Copy link
Member

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 10, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cc26b0b and 2 for PR HEAD ed6b7fd in total

@cgwalters
Copy link
Member Author

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8876c2c into openshift:release-4.13 Apr 11, 2023
7 checks passed
@openshift-ci-robot
Copy link

@cgwalters: Jira Issue OCPBUGS-11589 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

So that containers using rhel8 can read the host's journal directly.

xref https://issues.redhat.com/browse/LOG-3832

We can remove this in 4.14 hopefully, and almost certainly 4.15.

(cherry picked from commit 5bcda9b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants