Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-14847, OCPBUGS-11768: overlay.d: move 30gcp-udev-rules overlay to RHCOS #1312

Merged
merged 2 commits into from Jun 12, 2023
Merged

[release-4.13] OCPBUGS-14847, OCPBUGS-11768: overlay.d: move 30gcp-udev-rules overlay to RHCOS #1312

merged 2 commits into from Jun 12, 2023

Conversation

dustymabe
Copy link
Member

No description provided.

@dustymabe
Bump fedora-coreos-config submodule
3663737 
```
$ git -C fedora-coreos-config shortlog --no-merges  ed7f4f22..88d62812
Dusty Mabe (2):
      manifests/fedora-coreos-base: re-organize arch includes package list comments
      .cci.jenkinsfile: disable testing on older RHCOS branch

Renata Ravanelli (1):
      Add google-compute-engine-guest-configs-udev package; drop 30gcp-udev-rules overlay
```
@dustymabe
overlay.d: move 30gcp-udev-rules overlay to RHCOS
8f5bb2f 
These files were dropped from the FCOS overlay in [1] because
they are now being delivered via the google-compute-engine-guest-configs-udev
subpackage. Until this package exists in RHEL we'll add an overlay
to RHCOS with the rules (they have now been updated to match latest
upstream).

[1] coreos/fedora-coreos-config#2450

(cherry picked from commit 2513047)
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023
@dustymabe dustymabe changed the base branch from master to release-4.13 June 9, 2023 16:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023
@openshift-ci openshift-ci bot requested review from jmarrero and ravanelli June 9, 2023 16:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@dustymabe dustymabe mentioned this pull request Jun 9, 2023
Merged
@dustymabe
Copy link
Member Author

/retest

@dustymabe dustymabe closed this Jun 9, 2023
@dustymabe dustymabe reopened this Jun 9, 2023
travier
travier approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2023

@travier: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos-92-build-test-metal
  • /test rhcos-92-build-test-qemu
  • /test validate

Use /test all to run all jobs.

In response to this:

/test ci/prow/imaes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 9, 2023

/test images

@travier
Copy link
Member

travier commented Jun 9, 2023

/retest

2 similar comments
@travier
Copy link
Member

travier commented Jun 9, 2023

/retest

@dustymabe
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2023 •
edited

@dustymabe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-92-build-test-qemu 8f5bb2f link true /test rhcos-92-build-test-qemu
ci/prow/validate 8f5bb2f link true /test validate
ci/prow/images 8f5bb2f link true /test images
ci/prow/rhcos-92-build-test-metal 8f5bb2f link true /test rhcos-92-build-test-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented Jun 12, 2023

As this was opened for master initially, this confused Prow and thus the SCOS tests are there but they are not run anymore on 4.13 normally.

@travier
Copy link
Member

travier commented Jun 12, 2023

/label backport-risk-assessed
/label cherry-pick-approved
/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@travier: Overrode contexts on behalf of travier: ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved
/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 12, 2023

/jira refresh

@openshift-ci-robot
Copy link

@travier: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 12, 2023

/retitle [release-4.13] OCPBUGS-11768, OCPBUGS-14847: overlay.d: move 30gcp-udev-rules overlay to RHCOS

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-13754 overlay.d: move 30gcp-udev-rules overlay to RHCOS [release-4.13] OCPBUGS-11768, OCPBUGS-14847: overlay.d: move 30gcp-udev-rules overlay to RHCOS Jun 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 12, 2023
@openshift-ci-robot
Copy link

@dustymabe: This pull request references Jira Issue OCPBUGS-14847, which is invalid:

  • expected the bug to target the "4.13.z" version, but no target version was set
  • expected dependent Jira Issue OCPBUGS-13754 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-13754 to target a version in 4.14.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 12, 2023
@travier
Copy link
Member

travier commented Jun 12, 2023

/jira refresh

@openshift-ci-robot
Copy link

@travier: This pull request references Jira Issue OCPBUGS-14847, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13754 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 12, 2023 •
edited

The bot only picks one Jira card apparently. This is for:

We'll have to move one of those two cards manually to MODIFIED once this is merged.

Parents bugs for above for 4.14:

HuijingHei
HuijingHei approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@HuijingHei HuijingHei left a comment •
edited by dustymabe

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, HuijingHei, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,dustymabe,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Member

travier commented Jun 12, 2023

/retitle [release-4.13] OCPBUGS-14847, OCPBUGS-11768: overlay.d: move 30gcp-udev-rules overlay to RHCOS

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-11768, OCPBUGS-14847: overlay.d: move 30gcp-udev-rules overlay to RHCOS [release-4.13] OCPBUGS-14847, OCPBUGS-11768: overlay.d: move 30gcp-udev-rules overlay to RHCOS Jun 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2023
@openshift-ci-robot
Copy link

@dustymabe: This pull request references Jira Issue OCPBUGS-11768, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7582 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7582 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen June 12, 2023 14:40
@travier
Copy link
Member

travier commented Jun 12, 2023 •
edited

I'm switching this around as we already have one bug verified out of the two.

@openshift-merge-robot openshift-merge-robot merged commit 8c94b9f into openshift:release-4.13 Jun 12, 2023
7 checks passed
@openshift-ci-robot
Copy link

@dustymabe: Jira Issue OCPBUGS-11768: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11768 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuijingHei HuijingHei HuijingHei approved these changes

@travier travier travier approved these changes

@jmarrero jmarrero Awaiting requested review from jmarrero

@ravanelli ravanelli Awaiting requested review from ravanelli

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dustymabe @travier @openshift-ci-robot @HuijingHei @openshift-merge-robot