Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: remove wasm extension from C9S #1330

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

sohankunkerkar
Copy link
Member

crun-wasm isn't built for C9S, so skip this to avoid SCOS build failure.

@LorbusChris
Copy link
Member

Thanks for filing this!

Please do something like aa88c1c.
and ideally also open a ticket to get crun-wasm built for C9S asap.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@sohankunkerkar
Copy link
Member Author

Thanks for filing this!

Please do something like aa88c1c. and ideally also open a ticket to get crun-wasm built for C9S asap.

Sure, but crun-wasm isn't there in RHEL9 yet and the package is built specifically for OCP users.

@cgwalters
Copy link
Member

Yeah, it'd need to be built by an OCP process. But I think what we're running straight into here is that basically building RPMs and OCP stinks; there's tons of automation around container images that are shared between CI/ART but not rpms.

Long term what I think would make the most sense is to have gitlab.com/redhat/ocp/rpms with infrastructure that mirrors that on gitlab.com/redhat/centos-stream or so. (But this runs into a lot of interesting open questions around integrating Prow and our CI with gitlab...)

@LorbusChris
Copy link
Member

I've been doing builds of those RPMs (i.e. ones not in Stream/RHEL) on https://cbs.centos.org through the CentOS Cloud SIG, but manual maintenance is obviously not ideal.

I have opened RFEs to get support for packit.dev build automation on both the CBS and the Stream koji instances:

The Packit team is looking to prioritize these, please leave a comment there if you'd find this useful too.

@sohankunkerkar could you comment the lines out instead of removing them for now until we have an RPM build?

@sohankunkerkar
Copy link
Member Author

@sohankunkerkar could you comment the lines out instead of removing them for now until we have an RPM build?

Done!

@travier
Copy link
Member

travier commented Jul 10, 2023

/lgtm
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
extensions-c9s.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2023
crun-wasm isn't built for C9S, so skip this to avoid
SCOS build failure.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@sohankunkerkar
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member

Both SCOS and RHCOS 9.2 build-test-qemu both timed out. Trying again
/retest

@sohankunkerkar
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, sohankunkerkar, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@sohankunkerkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 64e21bb into openshift:master Jul 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants