-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COS-1935: overlay: include 40grub overlay from FCOS configs #1413
COS-1935: overlay: include 40grub overlay from FCOS configs #1413
Conversation
See coreos/fedora-coreos-config#2769 This won't really have any effect right now but will enable someone to use the generated ociarchive container images in the OSBuild workflow that calls bootupctl with the --with-static-configs argument.
@dustymabe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jmarrero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dustymabe: This pull request references COS-1935 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
See coreos/fedora-coreos-config#2769
This won't really have any effect right now but will enable someone to use the generated ociarchive container images in the OSBuild workflow that calls bootupctl with the --with-static-configs argument.