Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2484,OCPCLOUD-2481: Adds acr and gcr image credential providers #1444

Conversation

theobarberbany
Copy link
Contributor

This change adds the azure acr-image-credential-provider and gcp gcr-image-credential-provider packages that kubelet will use to retrieve authentication credentials

This change adds the azure acr-image-credential-provider and gcp
gcr-image-credential-provider packages that kubelet will use to retrieve authentication credentials
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@theobarberbany: This pull request references OCPCLOUD-2484 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

This pull request references OCPCLOUD-2481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This change adds the azure acr-image-credential-provider and gcp gcr-image-credential-provider packages that kubelet will use to retrieve authentication credentials

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@theobarberbany: This pull request references OCPCLOUD-2484 which is a valid jira issue.

This pull request references OCPCLOUD-2481 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany theobarberbany changed the title OCPCLOUD-2484,OCPCLOUD-2481:Adds acr and gcr image credential providers OCPCLOUD-2484,OCPCLOUD-2481: Adds acr and gcr image credential providers Feb 19, 2024
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@theobarberbany
Copy link
Contributor Author

/hold

Until we have CI RPMs in the artifacts image, so we don't break OKD builds

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@LorbusChris
Copy link
Member

OKD composes are currently halted. While I'd still prefer for the RPMs to land in artifacts first, OKD does not block this. Feel free to unhold.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@jlebon
Copy link
Member

jlebon commented Feb 20, 2024

/approve
/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, LorbusChris, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 973b01d into openshift:master Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants