Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: ci/prow-entrypoint: build extensions-container instead #1468

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 20, 2024

The cosa buildextend-extensions command is deprecated and its
output has not been used in RHCOS/OCP for a while. Test the extensions
container instead.

See also coreos/coreos-assembler#3765.

The `cosa buildextend-extensions` command is deprecated and its
output has not been used in RHCOS/OCP for a while. Test the extensions
container instead.

See also coreos/coreos-assembler#3765.
@openshift-ci openshift-ci bot requested review from cverna and marmijo March 20, 2024 20:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@dustymabe dustymabe added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 20, 2024
@dustymabe
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon jlebon changed the title ci/prow-entrypoint: build extensions-container instead NO-JIRA: ci/prow-entrypoint: build extensions-container instead Mar 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

The cosa buildextend-extensions command is deprecated and its
output has not been used in RHCOS/OCP for a while. Test the extensions
container instead.

See also coreos/coreos-assembler#3765.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member Author

jlebon commented Mar 21, 2024

/label acknowledge-critical-fixes-only

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bbd5744 into openshift:master Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants