Add .prow.sh script #3
Conversation
openshift-ci-robot
added
the
size/XS
.prow.sh
Outdated
|
|
||
| yum -y install jq | ||
| for jsonfile in *.json; do | ||
| jq < $jsonfile >/dev/null |
There was a problem hiding this comment.
Hi, might be a dumb question, but do you mind elaborating a bit what does this line do?(Does it just check the validity of each json files). I was also confused about the usage of jq < $file vs jq $file, do you have pointers to look at for usage of < in bash? Thanks, =)
There was a problem hiding this comment.
Exactly! It'll check that the JSON files are valid. Just a simple check that can be used for now until we have more sophisticated PR tests. < means feeding the file as the program's standard input: http://tldp.org/HOWTO/Bash-Prog-Intro-HOWTO-3.html
Let's keep it simple here so that we can more easily keep our CI scripts self-contained within the repo, a-la-PAPR/Travis CI. See also openshift/os#3.
This works in tandem with the changes in openshift/release#841.
openshift-ci-robot
added
size/S
| yum -y install jq | ||
| for jsonfile in *.json; do | ||
| echo "Checking JSON syntax for $jsonfile" | ||
| jq < $jsonfile . >/dev/null |
There was a problem hiding this comment.
The . here is needed to work around a bug where jq will refuse to work if redirecting output to something that's not a TTY: jqlang/jq#1351.
|
/lgtm |
Let's keep it simple here so that we can more easily keep our CI scripts self-contained within the repo, a-la-PAPR/Travis CI. See also openshift/os#3.
This works in tandem with the changes in
openshift/release#841.