Use Makefile to separate responsibilities a bit more #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's standardize on the `Makefile` as the CLI-friendly approach for local development. E.g. `make syntax-check` to verify that the JSON files are sane, and `make container` to build an update-in-container. OTOH, `.prow.sh` still does `yum -y install jq`. My goal is to then add more Makefile targets that can be used by humans as well as by various CIs.
openshift-ci-robot
added
the
size/S
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's standardize on the
Makefileas the CLI-friendly approach forlocal development. E.g.
make syntax-checkto verify that the JSONfiles are sane, and
make containerto build an update-in-container.OTOH,
.prow.shstill doesyum -y install jq.My goal is to then add more Makefile targets that can be used by humans
as well as by various CIs.