Bug 1908462: manifest: Re-add dhclient #486
Conversation
|
/retitle Bug 1908462: manifest: Re-add dhclient |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@LorbusChris: This pull request references Bugzilla bug 1908462, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can you add a link to the related RHBZ(s) in the commit message? |
|
Please test that the default DHCP client of an RHCOS system going from 4.6 -> 4.7 is not changed by the addition of the binaries. Additionally, test that using a conf file to configure NM to use |
LorbusChris
force-pushed
the
re-add-dhclient
branch
from
33efb6e
to
4666e54
Compare
|
@LorbusChris: This pull request references Bugzilla bug 1908462, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Should be fairly easy to add a kola test case for this that provides that Ignition config and uses e.g. And similarly, we could change our |
LorbusChris
force-pushed
the
re-add-dhclient
branch
2 times, most recently
from
211b803
to
5d43626
Compare
|
/approve |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Interesting. It's possible this is related. |
|
/lgtm cancel |
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
OK and I verified that building locally current git master running To debug locally use e.g. |
LorbusChris
force-pushed
the
re-add-dhclient
branch
3 times, most recently
from
9ec40ac
to
f499384
Compare
|
Hm ok, it seems this issue is triggered by the re-addition of the dhclient binaries. The NTP server specified in the |
With this, the dhclient binaries are added back to the RHCOS base. Usage of dhclient as DHCP client in the initramfs remains unsupported. In the real root, dhclient can be used as long as a configuration is provided. In order to activate dhclient and use it instead of NetworkManager's internal DHCP client in the real root, the user has to provide a configuration snippet via Ignition to configure NM to use dhclient, e.g. in `/etc/NetworkManager/conf.d/dhclient.conf`: ``` [main] dhcp=dhclient ``` Notably, the NetworkManager dispatcher script for dhclient.d config snippets remains excluded from the image. This means if the admin desires to e.g. configure NTP via DHCP using dhclient, a NM dispatcher script must be provided and placed at `/etc/NetworkManager/dispatcher.d/11-dhclient` ([1]), so the `/etc/dhcp/dhclient.d/chrony.sh` script that is shipped with the chrony package is executed. [1] https://src.fedoraproject.org/rpms/dhcp/blob/master/f/11-dhclient RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1908462
Adds a test to `misc-ro` to ensure that NetworkManager's internal DHCP client is used by default.
Adds a test that ensures dhclient can be used with a config provided via Ignition that explicitly enables it.
LorbusChris
force-pushed
the
re-add-dhclient
branch
from
f499384
to
8d7c0e5
Compare
overlay.d/21dhcp-chrony/etc/NetworkManager/dispatcher.d/20-coreos-chrony-dhcp
Show resolved
Hide resolved
|
@LorbusChris: This pull request references Bugzilla bug 1908462, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@LorbusChris: All pull requests linked via external trackers have merged: Bugzilla bug 1908462 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With this, the dhclient binaries are added back to the RHCOS base.
Usage of dhclient as DHCP client in the initramfs remains unsupported.
In the real root, dhclient can be used as long as a configuration is provided.
In order to activate dhclient and use it instead of NetworkManager's internal DHCP client in the real root,
the user has to provide a configuration snippet via Ignition to configure NM to use dhclient,
e.g. in
/etc/NetworkManager/conf.d/dhclient.conf:Notably, the NetworkManager dispatcher script for dhclient.d config snippets remains excluded from the image.
This means if the admin desires to e.g. configure NTP via DHCP using dhclient,
a NM dispatcher script must be provided and placed at
/etc/NetworkManager/dispatcher.d/11-dhclient([1]),so the
/etc/dhcp/dhclient.d/chrony.shscript that is shipped with the chrony package is executed.[1] https://src.fedoraproject.org/rpms/dhcp/blob/master/f/11-dhclient
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1908462