Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Exclude unneeded udisks2 #545

Merged
merged 1 commit into from Apr 29, 2021

Conversation

travier
Copy link
Member

@travier travier commented Apr 29, 2021

With RHEL 8.4, fwupd got pulled in as provider of dbxtool and that also
included udisks2 as a recommends. But udisks2 is apparently only needed
for encrypted swap checks in fwupd and is not even included in FCOS, so
manually exclude it.

For BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1953105

With RHEL 8.4, fwupd got pulled in as provider of dbxtool and that also
included udisks2 as a recommends. But udisks2 is apparently only needed
for encrypted swap checks in fwupd and is not even included in FCOS, so
manually exclude it.
@travier
Copy link
Member Author

travier commented Apr 29, 2021

@hughsie Could you confirm that udisks2 is not strictly required for firmware updates in fwupd? Thanks!

@hughsie
Copy link

hughsie commented Apr 29, 2021

udisks2 is not strictly required for firmware updates in fwupd

We indeed use it to find the ESP partition, but admins can hardcode this in /etc/fwupd/uefi_capsule.conf instead if required. If you're not using any plugins that use the ESP then you don't need udisks. I guess that depends on if you're ever likely to see a capsule update in reality on openshift.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@cgwalters
Copy link
Member

We indeed use it to find the ESP partition, but admins can hardcode this in /etc/fwupd/uefi_capsule.conf instead if required.

Regarding the ESP: coreos/fedora-coreos-config#794

Ultimately we may need a shared userspace component for dealing with the ESP, which may be bootupd. Not sure.

@cgwalters
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit fde7db4 into openshift:master Apr 29, 2021
@travier travier deleted the udisks2 branch April 30, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants