Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] Bug 1974411: Bump fedora-coreos-config submodule to latest #587

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jul 19, 2021

Jonathan Lebon (3):
      35coreos-live: stop overriding NetworkManager-wait-online timeout to 5s
      coreos-propagate-multipath-conf: trigger emergency.target on failure
      coreos-propagate-multipath-conf: run After=initrd-root-fs.target

For https://bugzilla.redhat.com/show_bug.cgi?id=1974411 and
https://bugzilla.redhat.com/show_bug.cgi?id=1967483.

```
Jonathan Lebon (3):
      35coreos-live: stop overriding NetworkManager-wait-online timeout to 5s
      coreos-propagate-multipath-conf: trigger emergency.target on failure
      coreos-propagate-multipath-conf: run After=initrd-root-fs.target
```

For https://bugzilla.redhat.com/show_bug.cgi?id=1974411 and
https://bugzilla.redhat.com/show_bug.cgi?id=1967483.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@jlebon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Bump fedora-coreos-config submodule to latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ashcrow and zonggen July 19, 2021 16:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@jlebon jlebon changed the title [release-4.8] Bump fedora-coreos-config submodule to latest [release-4.8] Bug 1974411: Bump fedora-coreos-config submodule to latest Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@jlebon: This pull request references Bugzilla bug 1974411, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1982001 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1982001 to target a release in 4.9.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1974411: Bump fedora-coreos-config submodule to latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021
@jlebon
Copy link
Member Author

jlebon commented Jul 19, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@jlebon: This pull request references Bugzilla bug 1974411, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead
  • expected dependent Bugzilla bug 1982001 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1982001 to target a release in 4.9.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

miabbott commented Jul 19, 2021

While BZ#1974411 is fixed with this code change, actually delivering the fix to customers requires a boot image bump in the installer via BZ#1982001. The BZ bot does not understand this dependency, so we have to manually remove the invalid-bug flag.

@miabbott miabbott removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 19, 2021
@miabbott
Copy link
Member

miabbott commented Jul 19, 2021

/bugzilla refresh

I updated the sev/pri on the BZ, let's see if the bot is smart enough to keep the invalid-bug label off...

edit:

Narrator: It is not.

@openshift-ci openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@miabbott: This pull request references Bugzilla bug 1974411, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead
  • expected dependent Bugzilla bug 1982001 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1982001 to target a release in 4.9.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

I updated the sev/pri on the BZ, let's see if the bot is smart enough to keep the invalid-bug label off...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021
@miabbott miabbott removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 19, 2021
@miabbott
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 354c7da into openshift:release-4.8 Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@jlebon: All pull requests linked via external trackers have merged:

Bugzilla bug 1974411 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1974411: Bump fedora-coreos-config submodule to latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon deleted the pr/bump-fcos-4.8-20210719 branch April 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants