Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial overlay #6

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented May 9, 2018

Place to build on for generating RPMs for each upstream repo that we then layer into the compose.

Signed-off-by: Steve Milner <smilner@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2018
overlay.yml Outdated

components:
- src: github:projectatomic/docker
branch: docker-1.13.1-rhel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashcrow, @peterbaouoft and myself tested this overlay file and it looks like we need to override the version here with override-version: "1.13.1"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Signed-off-by: Steve Milner <smilner@redhat.com>
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

- name: github
url: https://github.com/

- name: fedorapkgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: seems like if we plan to build all rpms from git repos, we don't need the fedorapkgs(as we are not fetching from it)? I happened to not include the cert and it passes. Only a minor tho :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fedorapkgs is used by the distgit section but you're correct that if we had spec files in each repo we wouldn't need it.

Copy link
Contributor

@peterbaouoft peterbaouoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM as well :).

@ashcrow
Copy link
Member Author

ashcrow commented May 10, 2018

/lgtm

@openshift-ci-robot
Copy link

@ashcrow: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member Author

ashcrow commented May 10, 2018

Can someone else lgtm?

@peterbaouoft
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2018
@openshift-merge-robot openshift-merge-robot merged commit 811a3d4 into openshift:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants