-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial overlay #6
Initial overlay #6
Conversation
Signed-off-by: Steve Milner <smilner@redhat.com>
overlay.yml
Outdated
|
||
components: | ||
- src: github:projectatomic/docker | ||
branch: docker-1.13.1-rhel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashcrow, @peterbaouoft and myself tested this overlay file and it looks like we need to override the version here with override-version: "1.13.1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Signed-off-by: Steve Milner <smilner@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM
- name: github | ||
url: https://github.com/ | ||
|
||
- name: fedorapkgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: seems like if we plan to build all rpms from git repos, we don't need the fedorapkgs(as we are not fetching from it)? I happened to not include the cert and it passes. Only a minor tho :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fedorapkgs is used by the distgit section but you're correct that if we had spec files in each repo we wouldn't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM as well :).
/lgtm |
@ashcrow: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can someone else lgtm? |
/lgtm |
Place to build on for generating RPMs for each upstream repo that we then layer into the compose.