-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdgo: build crio #7
Conversation
Signed-off-by: Steve Milner <smilner@redhat.com>
Signed-off-by: Steve Milner <smilner@redhat.com>
@@ -21,5 +18,10 @@ components: | |||
override-version: "1.13.1" | |||
branch: docker-1.13.1-rhel | |||
|
|||
# NOTE: master=1.11.0 which requires a different spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh OK. Hmm, yeah we'll have to adapt the spec file so we can track git master.
@@ -21,5 +18,10 @@ components: | |||
override-version: "1.13.1" | |||
branch: docker-1.13.1-rhel | |||
|
|||
# NOTE: master=1.11.0 which requires a different spec | |||
- src: github:kubernetes-incubator/cri-o | |||
override-version: "1.10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens without this? I see 1.10.1 tagged on the release-1.10
branch. I thought rdgo would pick up on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result I got was 1.9 rpms with 1.10.1 content.
/lgtm |
FWIW, WFM :).
|
This will build the latest commits off the 1.10 branch.