Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdgo: Switch to centos 7 mock root #9

Merged
merged 1 commit into from
May 10, 2018

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented May 10, 2018

Tested by building cri-o. No issues.

@ashcrow ashcrow requested a review from jlebon May 10, 2018 20:04
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2018
@jlebon
Copy link
Member

jlebon commented May 10, 2018

Nice! Have you tried the other components yet? If it works, then WDYT of just merging this overlay into the CAHC one for now? E.g. we'll also probably want git master rpm-ostree/ostree too, which is already building there. Though I agree there's an appeal to keeping this definition here.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2018
@openshift-merge-robot openshift-merge-robot merged commit d39e248 into openshift:master May 10, 2018
@miabbott
Copy link
Member

Nice! Have you tried the other components yet? If it works, then WDYT of just merging this overlay into the CAHC one for now? E.g. we'll also probably want git master rpm-ostree/ostree too, which is already building there. Though I agree there's an appeal to keeping this definition here.

You know, merging with CAHC would probably get us to PoC status faster than building out our own jobs. I'm not opposed to this idea. cc: @mike-nguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants