Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh-key-dir to el9 common pkgs #946

Closed
wants to merge 1 commit into from

Conversation

LorbusChris
Copy link
Member

@LorbusChris
Copy link
Member Author

/cc @travier
/cc @bgilbert

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LorbusChris
Once this PR has been reviewed and has the lgtm label, please assign saqibali-2k for approval by writing /assign @saqibali-2k in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgilbert
Copy link
Contributor

bgilbert commented Aug 9, 2022

Per discussion in coreos/fedora-coreos-config#1878, let's add this in a shared manifest in fedora-coreos-config instead.

This is on @marmijo's plate when he gets back from PTO. If you need this sooner, though, feel free to proceed with handling it yourself.

@bgilbert bgilbert closed this Aug 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scos-9-build-test-qemu ceae0ee link true /test scos-9-build-test-qemu
ci/prow/scos-9-build-test-metal ceae0ee link true /test scos-9-build-test-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Member Author

Thanks. This is a blocker for https://issues.redhat.com/browse/OKD-4, so I'll proceed with the addition over in fcos-config.

@LorbusChris
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants