Include raw http request in requests #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no way osin.Storage could obtain the raw http request. That make it impossible to use osin with GAE datastore or memcache as storage backend (both requires access to raw http request). It also limited the potential for storage engine to obtain extra bits for query purpose. In this commit, the raw request will be passed in AccessRequest and AuthorizeRequest struct. Hence Storage interface methods will get it.
|
I wanted to use osin as the auth layer in a project I'm doing. The project would most probably be hosted on GAE. However, all the storage facilities ( Please consider this. Thanks. |
|
I think it is better if the parameter is named "HttpRequest" instead of "Raw". |
As discussed in pull request #24, the parameters are renamed from "Raw" to "HttpRequest".
|
Renamed! |
RangelReale
added a commit
that referenced
this pull request
Aug 15, 2014
Include raw http request in requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no way osin.Storage could obtain the raw http request.
That make it impossible to use osin with GAE datastore or memcache
as storage backend (both requires access to raw http request).
It also limited the potential for storage engine to obtain extra
bits for query purpose.
In this commit, the raw request will be passed in AccessRequest and
AuthorizeRequest struct. Hence Storage interface methods will get it.