[4.12] OCPBUGS-18417: set TLS cipher suites in Kube RBAC sidecars

[dobsonj]

https://issues.redhat.com/browse/OCPBUGS-18417

• Bump library-go to get default TLS cipher suite list
• OCPBUGS-18417: set TLS cipher suites in Kube RBAC sidecars

cc @openshift/storage

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-18417, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-4347 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-4347 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-18417

• Bump library-go to get default TLS cipher suite list
• OCPBUGS-18417: set TLS cipher suites in Kube RBAC sidecars

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/retest

[dobsonj]

/label backport-risk-assessed

[openshift-ci]

@dobsonj: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/retest

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[engelmi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, engelmi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dobsonj,engelmi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/label backport-risk-assessed

[openshift-ci]

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[engelmi]

/label backport-risk-assessed

[duanwei33]

/label cherry-pick-approved

[openshift-ci]

@duanwei33: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duanwei33]

Checked CI result good and controller pod contains "tls-cipher-suites" in CI, looks good from QE side.

@leistnerova Could you help add the "cherry-pick-approved" label? Thanks!

[leistnerova]

Hi @duanwei33 I was not aware of any approved backport in OCP on RHV. How this should be tested?
What CI results are you referring to, is it installation of OCP on oVirt?

[duanwei33]

Hi @leistnerova, this is the CI job I checked, the "tls-cipher-suites" in present and the test result looks good. Do you think it is enough? (There is no function change)

$ w3m -dump 'https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_ovirt-csi-driver-operator/121/pull-ci-openshift-ovirt-csi-driver-operator-release-4.12-e2e-ovirt/1697336659172921344/artifacts/e2e-ovirt/gather-extra/artifacts/pods.json' | jq -r '.items[] | select(.metadata.name | match("ovirt-csi-driver-controller.*")).spec.containers[].args'  | grep tls-cipher-suites
  "--tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
  "--tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
  "--tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
  "--tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",

[dobsonj]

@leistnerova This resolves a CVE bug by dropping known insecure ciphers from the list of cipher suites that are accepted by Kube RBAC sidecars. Customers are noticing and asking for updates (see OCPBUGS-18417 ). The fix has already been in 4.13 for >9 months.

IMO, checking the ovirt-csi-driver-controller pods in the CI job as @duanwei33 did is sufficient to ensure the correct cipher list is passed to the controller deployment. That cipher list is consistent with all other CSI driver operators.

[leistnerova]

Thank you Wei and Jonathan for explanation. As this is no functional change, CI results are enough to verify and no further testing needed.
/label cherry-pick-approved

[openshift-ci-robot]

@dobsonj: Jira Issue OCPBUGS-18417: Some pull requests linked via external trackers have merged:

• openshift/azure-disk-csi-driver-operator#95
• openshift/azure-file-csi-driver-operator#71

The following pull requests linked via external trackers have not merged:

• openshift/openstack-cinder-csi-driver-operator#130 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18417 has not been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-18417

• Bump library-go to get default TLS cipher suite list
• OCPBUGS-18417: set TLS cipher suites in Kube RBAC sidecars

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.12.0-0.nightly-2023-09-11-105456