Bug 1899565: support raw block devices #57

bennyz · 2020-11-22T16:00:01Z

Add support for raw block PVCs

openshift-ci-robot · 2020-11-22T16:00:05Z

@bennyz: This pull request references Bugzilla bug 1898509, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1898509: support raw block devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rgolangh

overall looks good, small question inside

rgolangh · 2020-11-22T16:52:18Z

pkg/service/node.go

@@ -79,6 +86,10 @@ func (n *NodeService) NodeUnstageVolume(ctx context.Context, req *csi.NodeUnstag
 }

 func (n *NodeService) NodePublishVolume(ctx context.Context, req *csi.NodePublishVolumeRequest) (*csi.NodePublishVolumeResponse, error) {
+	if req.VolumeCapability == nil {
+		return nil, status.Errorf(codes.InvalidArgument, "Missing volume capability")


when does this happen (the VolumeCapability == nil)?

probably never, I'll remove

rgolangh · 2020-11-22T16:52:42Z

pkg/service/node.go

+	if req.VolumeCapability.GetBlock() != nil {
+		return n.publishBlockVolume(req, device)
+	}
+
 	targetPath := req.GetTargetPath()
 	err = os.MkdirAll(targetPath, 0750)


we should probably change this to 640 as well

bennyz · 2020-11-23T12:12:08Z

/bugzilla refresh

openshift-ci-robot · 2020-11-23T12:12:12Z

@bennyz: This pull request references Bugzilla bug 1899565, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-23T12:12:12Z

@bennyz: This pull request references Bugzilla bug 1899565, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1899565: support raw block devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rgolangh · 2020-11-23T15:23:22Z

pkg/service/node.go

+	err = mounter.Mount(device, req.TargetPath, "", []string{"bind"})
+	if err != nil {
+		if removeErr := os.Remove(req.TargetPath); removeErr != nil {
+			return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v", req.TargetPath, err)


here the removeErr is lost. Maybe wrap both of them?

rgolangh · 2020-11-23T18:23:45Z

pkg/service/node.go

+	err = mounter.Mount(device, req.TargetPath, "", []string{"bind"})
+	if err != nil {
+		if removeErr := os.Remove(req.TargetPath); removeErr != nil {
+			return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v", req.TargetPath, removeErr)


now the failing mount error is lost

right, sorry, I didn't get that at first

bennyz · 2020-11-25T09:25:29Z

pkg/service/node.go

+	err = mounter.Mount(device, req.TargetPath, "", []string{"bind"})
+	if err != nil {
+		if removeErr := os.Remove(req.TargetPath); removeErr != nil {
+			return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr,)


is there a nicer way?

your missing the err for the ErrorF, that's it I think:

return nil, status.Errorf( codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr, err)

Suggested change

return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr,)

return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr, err)

apparently trailing commas are allowed

This patch introduces support for block devices via CSI Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

openshift-merge-robot · 2020-11-25T15:30:46Z

@bennyz: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovirt	`91d4cd8`	link	`/test e2e-ovirt`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rgolangh · 2020-11-25T15:35:55Z

/lgtm

openshift-ci-robot · 2020-11-25T15:36:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennyz, rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bennyz,rgolangh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bennyz · 2020-11-25T16:00:26Z

/retest

openshift-bot · 2020-11-25T16:01:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-11-25T16:03:23Z

@bennyz: All pull requests linked via external trackers have merged:

openshift/ovirt-csi-driver#57

Bugzilla bug 1899565 has been moved to the MODIFIED state.

In response to this:

Bug 1899565: support raw block devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2021-01-28T13:26:32Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-01-28T13:27:06Z

@Gal-Zaidman: failed to push cherry-picked changes in GitHub: pushing failed, output: "remote: Repository not found.\nfatal: repository 'https://github.com/openshift-cherrypick-robot/ovirt-csi-driver/' not found\n", error: exit status 128

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2021-01-28T13:29:10Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-01-28T13:29:44Z

@Gal-Zaidman: failed to push cherry-picked changes in GitHub: pushing failed, output: "remote: Repository not found.\nfatal: repository 'https://github.com/openshift-cherrypick-robot/ovirt-csi-driver/' not found\n", error: exit status 128

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2021-01-28T15:50:22Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-01-28T15:50:56Z

@Gal-Zaidman: failed to push cherry-picked changes in GitHub: pushing failed, output: "remote: Repository not found.\nfatal: repository 'https://github.com/openshift-cherrypick-robot/ovirt-csi-driver/' not found\n", error: exit status 128

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2021-01-28T16:36:15Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-01-28T16:36:53Z

@stevekuznetsov: new pull request created: #68

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bennyz requested a review from rgolangh November 22, 2020 16:00

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 22, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2020

rgolangh reviewed Nov 22, 2020

View reviewed changes

bennyz changed the title ~~Bug 1898509: support raw block devices~~ Bug 1899565: support raw block devices Nov 23, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 23, 2020

bennyz requested a review from rgolangh November 23, 2020 12:25

rgolangh reviewed Nov 23, 2020

View reviewed changes

bennyz commented Nov 25, 2020

View reviewed changes

support raw block devices

91d4cd8

This patch introduces support for block devices via CSI Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

openshift-ci-robot assigned rgolangh Nov 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020

openshift-merge-robot merged commit e01eb6b into openshift:master Nov 25, 2020

bennyz deleted the support-raw-block branch November 25, 2020 19:19

openshift-cherrypick-robot mentioned this pull request Jan 28, 2021

[release-4.6] Bug 1921817: support raw block devices #68

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1899565: support raw block devices #57

Bug 1899565: support raw block devices #57

bennyz commented Nov 22, 2020

openshift-ci-robot commented Nov 22, 2020

rgolangh left a comment

rgolangh Nov 22, 2020

bennyz Nov 23, 2020

rgolangh Nov 22, 2020

bennyz Nov 23, 2020

bennyz commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

rgolangh Nov 23, 2020

bennyz Nov 23, 2020

rgolangh Nov 23, 2020

bennyz Nov 25, 2020

bennyz Nov 25, 2020

rgolangh Nov 25, 2020 •

edited

rgolangh Nov 25, 2020

bennyz Nov 25, 2020

bennyz Nov 25, 2020

openshift-merge-robot commented Nov 25, 2020 •

edited

rgolangh commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

bennyz commented Nov 25, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

stevekuznetsov commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

	return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr,)
	return nil, status.Errorf(codes.Internal, "Failed to remove mount target %v, err: %v, mount error: %v", req.TargetPath, removeErr, err)

Bug 1899565: support raw block devices #57

Bug 1899565: support raw block devices #57

Conversation

bennyz commented Nov 22, 2020

openshift-ci-robot commented Nov 22, 2020

rgolangh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bennyz commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgolangh Nov 25, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-merge-robot commented Nov 25, 2020 • edited

rgolangh commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

bennyz commented Nov 25, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

Gal-Zaidman commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

stevekuznetsov commented Jan 28, 2021

openshift-cherrypick-robot commented Jan 28, 2021

rgolangh Nov 25, 2020 •

edited

openshift-merge-robot commented Nov 25, 2020 •

edited