Skip to content

Commit

Permalink
OCPBUGS-2660: Add logging verbosity to configuring OVN logs
Browse files Browse the repository at this point in the history
When updating a large number of address_set, logs get flooded with
"Configuring OVN" which cannot be reduced.
Also klog shows up in the profiling data as a source of CPU consumption
of ovnkube-master.

We make it configurable and assign it a verbosity of 5. Default on
OpenShift is 4, however this log is redundant with the
"transacting operations" that is already logged with level 4.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-1643
Signed-off-by: François Rigault <frigo@amadeus.com>
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
  • Loading branch information
François Rigault authored and jluhrsen committed Oct 20, 2022
1 parent 54f32e8 commit 7bd50fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go-controller/pkg/libovsdbops/transact.go
Expand Up @@ -38,7 +38,7 @@ func TransactAndCheck(c client.Client, ops []ovsdb.Operation) ([]ovsdb.Operation
return []ovsdb.OperationResult{{}}, nil
}

klog.Infof("Configuring OVN: %+v", ops)
klog.V(5).Infof("Configuring OVN: %+v", ops)

ctx, cancel := context.WithTimeout(context.TODO(), types.OVSDBTimeout)
defer cancel()
Expand Down

0 comments on commit 7bd50fe

Please sign in to comment.