Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OVN to 22.03 #1033

Closed
wants to merge 27 commits into from
Closed

Bump OVN to 22.03 #1033

wants to merge 27 commits into from

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Apr 14, 2022

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@dceara
Copy link
Contributor

dceara commented Apr 14, 2022

/test images

2 similar comments
@dcbw
Copy link
Contributor Author

dcbw commented Apr 14, 2022

/test images

@dcbw
Copy link
Contributor Author

dcbw commented Apr 14, 2022

/test images

@dcbw
Copy link
Contributor Author

dcbw commented Apr 14, 2022

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2022
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
libovsdb List API worked with a pointer to a slice of structs, but now
it also supports a pointer to a slice of Models, with Models defined as
pointers to structs. This is more aligned with the rest of the API and
prevents conversions between the two forms.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
For ACLs:

* remove ModelClient usage outside of libovsdbops
* refactor libovsdbops to use ModelCLient

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Attempted mutations with nil or empty values are ignored and not
sent to the server as they would be an actual noop.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
Fixes adding nohostsubnets nodes (i.e. windows)
@dcbw
Copy link
Contributor Author

dcbw commented Apr 20, 2022

AWS issues:

level=error msg=Error: error listing tags for LB Target Group (arn:aws:elasticloadbalancing:us-east-2:460538899914:targetgroup/ci-op-0cs5iyi3-867e6-rnwfd-aext/0f28168f30fee3e4): TargetGroupNotFound: Target groups 'arn:aws:elasticloadbalancing:us-east-2:460538899914:targetgroup/ci-op-0cs5iyi3-867e6-rnwfd-aext/0f28168f30fee3e4' not found
level=error msg=	status code: 400, request id: a5208470-def7-4e19-a88d-125ae08545bc
level=error
level=error msg=  on ../tmp/openshift-install-cluster-2056103269/vpc/master-elb.tf line 71, in resource "aws_lb_target_group" "api_external":
level=error msg=  71: resource "aws_lb_target_group" "api_external" { 

/test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade

@dcbw
Copy link
Contributor Author

dcbw commented Apr 20, 2022

AWS issues:

level=error msg=Error: error listing tags for (arn:aws:elasticloadbalancing:us-east-1:460538899914:listener/net/ci-op-zidd20d1-9f5e1-9wmbw-ext/1d3756cdc47d6ea2/19cab1c24cc4f7de): ListenerNotFound: Listener 'arn:aws:elasticloadbalancing:us-east-1:460538899914:listener/net/ci-op-zidd20d1-9f5e1-9wmbw-ext/1d3756cdc47d6ea2/19cab1c24cc4f7de' not found
level=error msg=	status code: 400, request id: 056c1fad-108f-4aee-a0a9-3a446e4e8e30
level=error
level=error msg=  with module.vpc.aws_lb_listener.api_external_api[0],
level=error msg=  on vpc/master-elb.tf line 146, in resource "aws_lb_listener" "api_external_api":
level=error msg= 146: resource "aws_lb_listener" "api_external_api" {
level=error
level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: exit status 1
level=error
level=error msg=Error: error listing tags for (arn:aws:elasticloadbalancing:us-east-1:460538899914:listener/net/ci-op-zidd20d1-9f5e1-9wmbw-ext/1d3756cdc47d6ea2/19cab1c24cc4f7de): ListenerNotFound: Listener 'arn:aws:elasticloadbalancing:us-east-1:460538899914:listener/net/ci-op-zidd20d1-9f5e1-9wmbw-ext/1d3756cdc47d6ea2/19cab1c24cc4f7de' not found
level=error msg=	status code: 400, request id: 056c1fad-108f-4aee-a0a9-3a446e4e8e30
level=error
level=error msg=  with module.vpc.aws_lb_listener.api_external_api[0],
level=error msg=  on vpc/master-elb.tf line 146, in resource "aws_lb_listener" "api_external_api":
level=error msg= 146: resource "aws_lb_listener" "api_external_api" { 

/test e2e-aws-ovn-local-to-shared-gateway-mode-migration

@dcbw
Copy link
Contributor Author

dcbw commented Apr 20, 2022

Azure issues

 level=error msg=Error: waiting for creation of Linux Virtual Machine: (Name "ci-op-zidd20d1-e6384-rtgws-bootstrap" / Resource Group "ci-op-zidd20d1-e6384-rtgws-rg"): Code="AllocationFailed" Message="Allocation failed. We do not have sufficient capacity for the requested VM size in this region. Read more about improving likelihood of allocation success at http://aka.ms/allocation-guidance"
level=error
level=error msg=  with azurerm_linux_virtual_machine.bootstrap,
level=error msg=  on main.tf line 191, in resource "azurerm_linux_virtual_machine" "bootstrap":
level=error msg= 191: resource "azurerm_linux_virtual_machine" "bootstrap" {
level=error
level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: exit status 1
level=error
level=error msg=Error: waiting for creation of Linux Virtual Machine: (Name "ci-op-zidd20d1-e6384-rtgws-bootstrap" / Resource Group "ci-op-zidd20d1-e6384-rtgws-rg"): Code="AllocationFailed" Message="Allocation failed. We do not have sufficient capacity for the requested VM size in this region. Read more about improving likelihood of allocation success at http://aka.ms/allocation-guidance"
level=error
level=error msg=  with azurerm_linux_virtual_machine.bootstrap,
level=error msg=  on main.tf line 191, in resource "azurerm_linux_virtual_machine" "bootstrap":
level=error msg= 191: resource "azurerm_linux_virtual_machine" "bootstrap" { 

/test e2e-azure-ovn

@dcbw
Copy link
Contributor Author

dcbw commented Apr 20, 2022

AWS issues:

level=error msg=Error: error reading Route Table (rtb-07dd6bdd9fd7007dd): couldn't find resource
level=error
level=error msg=  with module.vpc.aws_route_table.default[0],
level=error msg=  on vpc/vpc-public.tf line 14, in resource "aws_route_table" "default":
level=error msg=  14: resource "aws_route_table" "default" {
level=error
level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: exit status 1
level=error
level=error msg=Error: error reading Route Table (rtb-07dd6bdd9fd7007dd): couldn't find resource
level=error
level=error msg=  with module.vpc.aws_route_table.default[0],
level=error msg=  on vpc/vpc-public.tf line 14, in resource "aws_route_table" "default":
level=error msg=  14: resource "aws_route_table" "default" { 

/test e2e-ovn-hybrid-step-registry

Copy link
Contributor

@jcaamano jcaamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcbw Do you think that NBDB will start without errors with the updated schema and multiple Copps with duplicate names ("")?

go-controller/pkg/libovsdbops/copp.go Outdated Show resolved Hide resolved
@jcaamano
Copy link
Contributor

@dcbw Do you think that NBDB will start without errors with the updated schema and multiple Copps with duplicate names ("")?

oops I got the wrong PR

libovsdb: cleanup ModelClient usage
Requires a bump of the libovsdb modelgen because our gen files
use the -extended option which landed in libovsdb in January.

Signed-off-by: Dan Williams <dcbw@redhat.com>
The COPP table is now indexed by name (which was actually requested
by us/ovn-kubernetes) but this means we need to set the name of
previously added COPP rows to prevent database consistency errors.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 1ec067f link true /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-local-gateway 1ec067f link true /test e2e-aws-ovn-local-gateway
ci/prow/okd-e2e-gcp-ovn 1ec067f link false /test okd-e2e-gcp-ovn
ci/prow/e2e-aws-ovn-upgrade 1ec067f link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn 1ec067f link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn 1ec067f link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw dcbw closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants