Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] debug ovn-controller #1073

Closed
wants to merge 16 commits into from
Closed

[wip] debug ovn-controller #1073

wants to merge 16 commits into from

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented May 2, 2022

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2022
@openshift-ci openshift-ci bot requested review from jcaamano and squeed May 2, 2022 14:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@dcbw
Copy link
Contributor Author

dcbw commented May 9, 2022

/test images

@dcbw dcbw force-pushed the controller-debug branch 3 times, most recently from 94b8a95 to 544d065 Compare May 19, 2022 15:40
tssurya
tssurya reviewed May 23, 2022
View reviewed changes
go-controller/pkg/ovn/pods.go Outdated
@@ -429,7 +429,7 @@ func (oc *Controller) addLogicalPort(pod *kapi.Pod) (err error) {

if needsIP {
// try to get the IP from existing port in OVN first
podMac, podIfAddrs, err = oc.getPortAddresses(logicalSwitch, portName)
podMac, podIfAddrs, err = oc.getPortAddresses(logicalSwitch, portName, existingLSP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow this is a nice catch! so we were again looking up LSP inside GetPortAddresses !

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2022
@dcbw
Copy link
Contributor Author

dcbw commented May 25, 2022

/test images

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@dcbw: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor

squeed commented Jul 18, 2022

/uncc

@openshift-ci openshift-ci bot removed the request for review from squeed July 18, 2022 04:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2022

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-hybrid-step-registry 39a0415 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 39a0415 link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-vsphere-windows 39a0415 link false /test e2e-vsphere-windows
ci/prow/e2e-metal-ipi-ovn-ipv6 39a0415 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn 39a0415 link true /test e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack 39a0415 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-upgrade 39a0415 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-windows 39a0415 link true /test e2e-aws-ovn-windows
ci/prow/okd-e2e-gcp-ovn 39a0415 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-openstack-ovn 39a0415 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn 39a0415 link false /test e2e-vsphere-ovn
ci/prow/4.12-upgrade-from-stable-4.11-images 39a0415 link true /test 4.12-upgrade-from-stable-4.11-images
ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-images 39a0415 link true /test 4.12-upgrade-from-stable-4.11-local-gateway-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2022
@dcbw dcbw closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya left review comments

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dcbw @squeed @openshift-bot @tssurya