Bug 2070929: Downstream Merge: 04-05-2022 #1078
Conversation
We do not need to start a recording of pod setup within OVN when theres an error. This was introduced in recent changes. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Theres no need to hold it in memory anymore when we have calculated all the metrics required for this pod. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
NOOP is not enough when we want to actually test controllers that rely on SetIPs. Deleting all IPs and adding the provided ones should be good enough. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
When using the namespace's address_set for the EgressQoS rule we should return an empty map rather than nil, otherwise when we try to load from it in the pod sync path we get a nil pointer dereference. Using an empty map is fine since we don't want to change anything in the namespace's address_set here. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Adding E2E tests that cover EgressQoS functionality for both IPv4 and IPv6: * First table verifies that a pod's egress traffic is marked with the correct DSCP value on EgressQoS resource updates regardless if it was created before or after the resource. * Second table verifies that updating a pod's labels results in the right QoS rules being applied to its egress traffic. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
If the pod isn't yet scheduled, we should just ignore the event and try again later when we get the update event. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
The way we currently log is too noisy for cases we don't care about EgressQoS. Logging pods now only when we're going to do something with them. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
This commit ensures invalid or unassigned egress ip entry is also removed from cloudprivateipconfig when egressip resource is deleted. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
We should be deleting the snat towards nodeIP before adding snat towards egressIP only from the node where the pod lives if that same node is serving as the egressIPnode for the pod. A second problem that was fixed was in deleteEgressIPAssignments we were re-adding the setup for SNAT towards nodeIP only if pod had no egressIPs attached to it, which is wrong since depending on the location of the pod, we'd need to re-add the SNAT towards nodeIP even if the pod is being served by another egressIP. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Add Egress QoS E2E and fix panic
v1beta1 will be removed in 1.25 Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
v1beta1 will be removed in 1.25 Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Fix pod recorder and improve it
Delete invalid egress ip from cloudprivateipconfig
Don't warn on failure to create pod when it isn't scheduled
delete SNAT2NIP if pod.node == egressNodeServingPod
Bump PodDisruptionBudget and EndpointSlice to v1
openshift-ci
bot
added
bugzilla/severity-high
|
@tssurya: This pull request references Bugzilla bug 2070929, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@tssurya: This pull request references Bugzilla bug 2070929, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/retest |
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tssurya: All pull requests linked via external trackers have merged: Bugzilla bug 2070929 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @tssurya ! |
cc @martinkennelly @oribon @pperiyasamy