Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2086851: enable exportloopref linter and fix violations #1092

Merged
merged 1 commit into from May 17, 2022
Merged

Bug 2086851: enable exportloopref linter and fix violations #1092

merged 1 commit into from May 17, 2022

Conversation

trozet
Copy link
Contributor

@trozet trozet commented May 16, 2022

exportloopref golangci linter finds pointers exported from within
for-range loop, see https://github.com/kyoh86/exportloopref for details.

The linter does expose 2 violations, the one in pkg/ovn/pods.go is a
real bug.

Signed-off-by: xqu xqu@nvidia.com
(cherry picked from commit 4248a33)

@trozet
enable exportloopref linter and fix violations
a24656d 
`exportloopref` golangci linter finds pointers exported from within
for-range loop, see https://github.com/kyoh86/exportloopref for details.

The linter does expose 2 violations, the one in `pkg/ovn/pods.go` is a
real bug.

Signed-off-by: xqu <xqu@nvidia.com>
(cherry picked from commit 4248a33)
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

@trozet: This pull request references Bugzilla bug 2086851, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2086851: enable exportloopref linter and fix violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@tssurya
Copy link
Contributor

tssurya commented May 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trozet
Copy link
Contributor Author

trozet commented May 16, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@trozet: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tssurya
Copy link
Contributor

tssurya commented May 17, 2022

/test e2e-metal-ipi-ovn-dualstack

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tssurya
Copy link
Contributor

tssurya commented May 17, 2022

/test e2e-metal-ipi-ovn-dualstack

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@trozet
Copy link
Contributor Author

trozet commented May 17, 2022

the single test failure for dualstack has nothing to do with this patch:

{  fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:64]: incorrect number of voting members found in openshift-etcd/etcd-endpoints, expected it to match the number of master nodes = 6, members from the cm = [192.168.111.20 192.168.111.21 192.168.111.22], master nodes = [192.168.111.20 192.168.111.21 192.168.111.22 fd2e:6f44:5dd8:c956::14 fd2e:6f44:5dd8:c956::15 fd2e:6f44:5dd8:c956::16]}

/override ci/prow/e2e-metal-ipi-ovn-dualstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-dualstack

In response to this:

the single test failure for dualstack has nothing to do with this patch:

{  fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:64]: incorrect number of voting members found in openshift-etcd/etcd-endpoints, expected it to match the number of master nodes = 6, members from the cm = [192.168.111.20 192.168.111.21 192.168.111.22], master nodes = [192.168.111.20 192.168.111.21 192.168.111.22 fd2e:6f44:5dd8:c956::14 fd2e:6f44:5dd8:c956::15 fd2e:6f44:5dd8:c956::16]}

/override ci/prow/e2e-metal-ipi-ovn-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d97126f into openshift:master May 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 2086851 has been moved to the MODIFIED state.

In response to this:

Bug 2086851: enable exportloopref linter and fix violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn a24656d link false /test e2e-vsphere-ovn
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade a24656d link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-gcp-ovn a24656d link false /test okd-e2e-gcp-ovn
ci/prow/e2e-azure-ovn a24656d link false /test e2e-azure-ovn
ci/prow/e2e-hypershift a24656d link false /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2022
Merged
@openshift-cherrypick-robot
Copy link

@trozet: new pull request created: #1095

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor Author

trozet commented May 17, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2022
Merged
@openshift-cherrypick-robot
Copy link

@trozet: new pull request created: #1096

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor Author

trozet commented May 17, 2022

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2022
Merged
@openshift-cherrypick-robot
Copy link

@trozet: new pull request created: #1097

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@dcbw dcbw Awaiting requested review from dcbw

@squeed squeed Awaiting requested review from squeed

Assignees

@tssurya tssurya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trozet @tssurya @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot