Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Make the image slightly smaller #11

Closed
wants to merge 1 commit into from
Closed

WIP: Make the image slightly smaller #11

wants to merge 1 commit into from

Conversation

danwinship
Copy link
Contributor

  • Use origin-cli as the base
  • Don't install containernetworking-plugins
  • Don't copy in ovn-kube-util

@danwinship
Make the image slightly smaller
4f1cee2 
- Use origin-cli as the base
- Don't install containernetworking-plugins
- Don't copy in ovn-kube-util
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship
To complete the pull request process, please assign dcbw
You can assign the PR to them by writing /assign @dcbw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

squeed
squeed reviewed Jun 24, 2019
View reviewed changes
Dockerfile
FROM openshift/origin-cli AS cli

FROM openshift/origin-base
FROM openshift/origin-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this is ignored by OSBS, so you'll have to update this in release too.

pecameron added a commit to pecameron/ovn-kubernetes-1 that referenced this pull request Sep 17, 2019
@pecameron
bug 1748162: - [GCP]Failed to install cluster with OVN network type
a64b3b2 
Comment openshift#11 redirects this to a vsphere bug
OVN as network type to install cluster on vsphere.

cannot load glue library: libibverbs.so.1

https://bugzilla.redhat.com/show_bug.cgi?id=1748162

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@pecameron pecameron mentioned this pull request Sep 17, 2019
Closed
@danwinship danwinship mentioned this pull request Oct 15, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

@danwinship: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ovn 4f1cee2 link /test e2e-aws-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

@danwinship: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2019
@danwinship danwinship closed this Apr 14, 2020
Billy99 added a commit to Billy99/ovn-kubernetes that referenced this pull request Nov 2, 2022
@Billy99
Merge pull request openshift#11 from Billy99/billy99-ovntrace-smartnic-2
b9bf5af 
Cleanup from move of yaml files to yaml/ directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed left review comments

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danwinship @openshift-ci-robot @squeed