Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted #1123

Merged
merged 1 commit into from Jun 15, 2022

Conversation

flavio-fernandes
Copy link
Contributor

Recent retry logic was a little too harsh on deletion when the port
is not present in the annotation.

Closes: #2973
Backport of ovn-org/ovn-kubernetes#2974

Signed-off-by: Flavio Fernandes flaviof@redhat.com

Recent retry logic was a little too harsh on deletion when the port
is not present in the annotation.

Closes: #2973
Backport of ovn-org/ovn-kubernetes#2974

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/assign @jcaamano

@flavio-fernandes
Copy link
Contributor Author

@tssurya PTAL

@tssurya
Copy link
Contributor

tssurya commented Jun 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@jcaamano
Copy link
Contributor

jcaamano commented Jun 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jcaamano, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD ff77341 and 8 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD ff77341 and 7 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ff77341 and 6 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 71bebe3 and 5 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 71bebe3 and 4 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 71bebe3 and 3 for PR HEAD 903660d in total

@flavio-fernandes
Copy link
Contributor Author

/retest-required

4 similar comments
@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD ab62636 and 2 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD ab62636 and 1 for PR HEAD 903660d in total

@flavio-fernandes
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@flavio-fernandes
Copy link
Contributor Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 4c79db5 and 8 for PR HEAD 903660d in total

@flavio-fernandes
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 4c79db5 and 7 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c79db5 and 6 for PR HEAD 903660d in total

@flavio-fernandes
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@dcbw
Copy link
Member

dcbw commented Jun 13, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6
metal v6 not coming up https://issues.redhat.com/browse/TRT-306

1 similar comment
@dcbw
Copy link
Member

dcbw commented Jun 13, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6
metal v6 not coming up https://issues.redhat.com/browse/TRT-306

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
metal v6 not coming up https://issues.redhat.com/browse/TRT-306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
metal v6 not coming up https://issues.redhat.com/browse/TRT-306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2092579. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 81c5ad9 and 5 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 81c5ad9 and 4 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 81c5ad9 and 3 for PR HEAD 903660d in total

@flavio-fernandes
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD afdb5dd and 2 for PR HEAD 903660d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD afdb5dd and 1 for PR HEAD 903660d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-windows 903660d link false /test e2e-vsphere-windows
ci/prow/okd-e2e-gcp-ovn 903660d link false /test okd-e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial 903660d link false /test e2e-aws-ovn-serial
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade 903660d link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD afdb5dd and 0 for PR HEAD 903660d in total

@openshift-ci openshift-ci bot merged commit 54c45b5 into openshift:master Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@flavio-fernandes: All pull requests linked via external trackers have merged:

Bugzilla bug 2092579 has been moved to the MODIFIED state.

In response to this:

[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes flavio-fernandes deleted the bz2092579_4.11 branch June 20, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants