New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted #1123
[release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted #1123
Conversation
Recent retry logic was a little too harsh on deletion when the port is not present in the annotation. Closes: #2973 Backport of ovn-org/ovn-kubernetes#2974 Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jcaamano |
@tssurya PTAL |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, jcaamano, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
4 similar comments
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/test e2e-metal-ipi-ovn-dualstack |
/test e2e-metal-ipi-ovn-ipv6 |
/remove-hold |
/test e2e-metal-ipi-ovn-ipv6 |
/test e2e-metal-ipi-ovn-ipv6 |
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
1 similar comment
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@flavio-fernandes: This pull request references Bugzilla bug 2092579. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@flavio-fernandes: This pull request references Bugzilla bug 2092579, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/test e2e-metal-ipi-ovn-ipv6 |
@flavio-fernandes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@flavio-fernandes: All pull requests linked via external trackers have merged: Bugzilla bug 2092579 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Recent retry logic was a little too harsh on deletion when the port
is not present in the annotation.
Closes: #2973
Backport of ovn-org/ovn-kubernetes#2974
Signed-off-by: Flavio Fernandes flaviof@redhat.com