Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2092889: update all egress ACLs' direction to "from-lport" #1128

Merged
merged 1 commit into from Jun 15, 2022
Merged

Bug 2092889: update all egress ACLs' direction to "from-lport" #1128

merged 1 commit into from Jun 15, 2022

Conversation

JacobTanenbaum
Copy link
Contributor

clean cherry-pick of upstream commit bc941c2

Direction of the ACLs built for multicast egress policy was always
"from-lport", so we cannot determine if we need to update egress ACL
direction based on the first egress ACL that found.

Signed-off-by: Yun Zhou yunz@nvidia.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@cathy-zhou @JacobTanenbaum
update all egress ACLs' direction to "from-lport"
174aed7 
Direction of the ACLs built for multicast egress policy was always
"from-lport", so we cannot determine if we need to update egress ACL
direction based on the first egress ACL that found.

Signed-off-by: Yun Zhou <yunz@nvidia.com>
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@JacobTanenbaum: This pull request references Bugzilla bug 2092895, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2092895: update all egress ACLs' direction to "from-lport"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from abhat and dcbw June 3, 2022 17:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@JacobTanenbaum
Copy link
Contributor Author

/retest

looks like something from the ci system messed up

@JacobTanenbaum JacobTanenbaum changed the title Bug 2092895: update all egress ACLs' direction to "from-lport" Bug 2092889: update all egress ACLs' direction to "from-lport" Jun 6, 2022
@JacobTanenbaum
Copy link
Contributor Author

/bugzilla-refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2022

@JacobTanenbaum: This pull request references Bugzilla bug 2092889, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2092889: update all egress ACLs' direction to "from-lport"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JacobTanenbaum
Copy link
Contributor Author

/retest

@bear-redhat
Copy link

/retest

@andreaskaris
Copy link
Contributor

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2022

@andreaskaris: The following commands are available to trigger required jobs:

  • /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • /test 4.11-upgrade-from-stable-4.10-images
  • /test 4.11-upgrade-from-stable-4.10-local-gateway-images
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-local-gateway
  • /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upgrade-local-gateway
  • /test e2e-aws-ovn-windows
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test gofmt
  • /test images
  • /test lint
  • /test okd-images
  • /test unit

The following commands are available to trigger optional jobs:

  • /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
  • /test e2e-azure-ovn
  • /test e2e-hypershift
  • /test e2e-metal-ipi-ovn-ipv4
  • /test e2e-openstack-ovn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-windows
  • /test okd-e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-ovn-kubernetes-master-4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-master-4.11-upgrade-from-stable-4.10-images
  • pull-ci-openshift-ovn-kubernetes-master-4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-master-4.11-upgrade-from-stable-4.10-local-gateway-images
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-gateway
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-upgrade-local-gateway
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-windows
  • pull-ci-openshift-ovn-kubernetes-master-e2e-azure-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-hypershift
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-ovn-kubernetes-master-e2e-openstack-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows
  • pull-ci-openshift-ovn-kubernetes-master-gofmt
  • pull-ci-openshift-ovn-kubernetes-master-images
  • pull-ci-openshift-ovn-kubernetes-master-lint
  • pull-ci-openshift-ovn-kubernetes-master-okd-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-master-okd-images
  • pull-ci-openshift-ovn-kubernetes-master-unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JacobTanenbaum
Copy link
Contributor Author

/retest

2 similar comments
@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

/retest

@trozet
Copy link
Contributor

trozet commented Jun 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JacobTanenbaum,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 81c5ad9 and 8 for PR HEAD 174aed7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JacobTanenbaum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 174aed7 link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit afdb5dd into openshift:master Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JacobTanenbaum: All pull requests linked via external trackers have merged:

Bugzilla bug 2092889 has been moved to the MODIFIED state.

In response to this:

Bug 2092889: update all egress ACLs' direction to "from-lport"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@dcbw dcbw Awaiting requested review from dcbw dcbw is a code owner

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JacobTanenbaum @bear-redhat @andreaskaris @trozet @openshift-ci-robot @openshift-merge-robot @cathy-zhou