Bug 2092501: Fixes finding default gateway for configured GW interface #1131
Conversation
The code for determining the default gateway was not taking into consideration if the gateway interfaces was provided via config and would return any default gateway found on the host. This is an issue when a system has more than 1 default gateway, as well as if a user provided an interface other than the real default gateway interface. If the gateway interface is provided via config, the code now scopes default routes found to only that interface. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 87db93d)
|
@tssurya PTAL |
trozet
changed the title
|
@trozet: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 2092501 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@trozet: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-high
|
@trozet: This pull request references Bugzilla bug 2092501, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
backport-risk-assessed
|
/label backport-risk-assessed |
|
/assign @anuragthehatter |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 2092501 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 2092501: Fixes finding default gateway for configured GW interface Signed-off-by: Patryk Diak <pdiak@redhat.com>
The code for determining the default gateway was not taking into
consideration if the gateway interfaces was provided via config and
would return any default gateway found on the host. This is an issue
when a system has more than 1 default gateway, as well as if a user
provided an interface other than the real default gateway interface.
If the gateway interface is provided via config, the code now scopes
default routes found to only that interface.
Signed-off-by: Tim Rozet trozet@redhat.com
(cherry picked from commit 87db93d)